Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add enable Endpoint Slices #17480

Closed
wants to merge 1 commit into from
+2 −0
Closed

add enable Endpoint Slices #17480

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions content/en/docs/concepts/services-networking/endpoint-slices.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,8 @@ endpoints:
topology.kubernetes.io/zone: us-west2-a
```
Additionally, you must [enable Endpoint Slices](/docs/tasks/administer-cluster/enabling-endpoint-slices/#enabling-endpoint-slices) first.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about moving this detail to the start of the main contents (say line 26)?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, the link to the task is on line 91 of this page.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kbhawkey, is it better to introduce this at the start?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sftim, moving this to the start is ok.

Copy link
Contributor

@kbhawkey kbhawkey Nov 10, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lojies , this page introduces the alpha feature, Endpoint Slices, and does not necessarily provide steps to create a working example.

Also, it looks like this feature is changing to beta in 1.17. See PR #17411 . Looks like the task page is going away.

I don't think the page needs two links to the Endpoint Slices task page. If you want to add a statement about enabling the feature gate, you may want to add a bit more context.
Suggestions:

See the What's next section for information about enabling Endpoint Slices.
or
You can follow the Endpoint Slices task to enable the Endpoint Slices feature.

Page preview:
https://deploy-preview-17480--kubernetes-io-master-staging.netlify.com/docs/concepts/services-networking/endpoint-slices/

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kbhawkey , thanks for the suggestion.I will close this pr.

By default, Endpoint Slices managed by the EndpointSlice controller will have no
more than 100 endpoints each. Below this scale, Endpoint Slices should map 1:1
with Endpoints and Services and have similar performance.
Expand Down