Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update DaemonSet scheduling version inconsistency #17476

Closed

Conversation

christophercarney
Copy link
Contributor

Fixes #17336

Check the issue for more details but in short: an update was made to the header specifying the default behavior when it switched over in 1.12 without modifying the intro paragraph (which still reflects that DaemonSet controller is the default scheduling behavior)

@k8s-ci-robot k8s-ci-robot requested a review from enisoc November 7, 2019 19:54
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 7, 2019
@k8s-ci-robot k8s-ci-robot requested a review from foxish November 7, 2019 19:54
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 7, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign tfogo
You can assign the PR to them by writing /assign @tfogo in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Nov 7, 2019
@netlify
Copy link

netlify bot commented Nov 7, 2019

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 79a23f0

https://deploy-preview-17476--kubernetes-io-master-staging.netlify.com

Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments

@sftim
Copy link
Contributor

sftim commented Nov 10, 2019

@christophercarney you might also have some thoughts on rewording https://github.com/kubernetes/website/pull/16885/files#diff-8342a130ee45184367af9dca4b6d6f2aR1
If you do, please feel free to make those suggestions!

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 12, 2019
@christophercarney
Copy link
Contributor Author

@sftim Made a few changes according to our discussion. Kept the rewording but moved the motivation for why DaemonSet controller is no longer the default behavior to the DaemonSet controller section to (hopefully) make it more clear both why default scheduler is the default behavior and that it is indeed the default.

Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy with these changes.

Bear in mind that this will go out of date when v1.17 is released (v1.12 will no longer be supported, so there's then a task about cleanup & simplifying).

@christophercarney
Copy link
Contributor Author

I’ll take note of that and circle back around to this at that time.

/assign @tfogo

@sftim
Copy link
Contributor

sftim commented Jan 15, 2020

This didn't get approved as yet.
@christophercarney are you willing to revise this now that v1.17 is out?

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 15, 2020
@k8s-ci-robot
Copy link
Contributor

@christophercarney: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kbhawkey
Copy link
Contributor

kbhawkey commented Feb 8, 2020

Hello @christophercarney , Do you have time to follow-up on this PR (and rebase as well)?

@sftim
Copy link
Contributor

sftim commented Feb 23, 2020

@christophercarney I'm going to close this PR. Please feel free to rebase your work against master and open a new similar pull request with the same description.

/close

@k8s-ci-robot
Copy link
Contributor

@sftim: Closed this PR.

In response to this:

@christophercarney I'm going to close this PR. Please feel free to rebase your work against master and open a new similar pull request with the same description.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue with k8s.io/docs/concepts/workloads/controllers/daemonset/
5 participants