Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix grammar #17366

Merged
merged 1 commit into from
Nov 3, 2019
Merged

Fix grammar #17366

merged 1 commit into from
Nov 3, 2019

Conversation

Chihoon-Sung
Copy link
Contributor

@Chihoon-Sung Chihoon-Sung commented Nov 2, 2019

Grammar errors and spelling corrections

생생된 ->생성된 (오타)
뿐만 -> 그뿐만 (문법오류)
제공받은 -> 받은 (중복의미)
빌드된 -> 빌드 된(띄어쓰기)

/language ko

Grammar errors and spelling corrections
@k8s-ci-robot
Copy link
Contributor

Welcome @Chihoon-Sung!

It looks like this is your first PR to kubernetes/website 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/website has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Nov 2, 2019
@k8s-ci-robot k8s-ci-robot added area/blog Issues or PRs related to the Kubernetes Blog subproject language/en Issues or PRs related to English language language/id Issues or PRs related to Indonesian language language/zh Issues or PRs related to Chinese language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Nov 2, 2019
@Chihoon-Sung
Copy link
Contributor Author

Chihoon-Sung commented Nov 2, 2019

/remove-language en
/remove-language zh
/remove-language id

@k8s-ci-robot k8s-ci-robot removed language/en Issues or PRs related to English language language/zh Issues or PRs related to Chinese language language/id Issues or PRs related to Indonesian language labels Nov 2, 2019
@netlify
Copy link

netlify bot commented Nov 2, 2019

Deploy preview for k8s-dev-ko ready!

Built with commit 19e5859

https://deploy-preview-17366--k8s-dev-ko.netlify.com

@Chihoon-Sung
Copy link
Contributor Author

/assign @ianychoi

@k8s-ci-robot
Copy link
Contributor

@Chihoon-Sung: The label(s) /label language/ko cannot be applied. These labels are supported: api-review, community/discussion, community/maintenance, community/question, cuj/build-train-deploy, cuj/multi-user, platform/aws, platform/azure, platform/gcp, platform/minikube, platform/other

In response to this:

/label language/ko

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Chihoon-Sung
Copy link
Contributor Author

/assign @seokho-son

@Chihoon-Sung
Copy link
Contributor Author

/assign @kbhawkey

@k8s-ci-robot k8s-ci-robot added the language/ko Issues or PRs related to Korean language label Nov 2, 2019
@k8s-ci-robot
Copy link
Contributor

@Chihoon-Sung: The label(s) /label language/ko cannot be applied. These labels are supported: api-review, community/discussion, community/maintenance, community/question, cuj/build-train-deploy, cuj/multi-user, platform/aws, platform/azure, platform/gcp, platform/minikube, platform/other

In response to this:

/label language/ko

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Chihoon-Sung
Copy link
Contributor Author

/assign @gochist

@gochist gochist changed the base branch from dev-1.16-ko.4 to master November 3, 2019 13:17
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Nov 3, 2019
@gochist
Copy link
Member

gochist commented Nov 3, 2019

@Chihoon-Sung 감사합니다!
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 3, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gochist

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 3, 2019
@k8s-ci-robot k8s-ci-robot merged commit 22ad2c6 into kubernetes:master Nov 3, 2019
@Chihoon-Sung
Copy link
Contributor Author

@Chihoon-Sung 감사합니다!
/lgtm
/approve

제 첫 리퀘스트를 받아주셔서 감사합니다!
혹시 제가 검토(오탈자 체크, 문법오류)하거나 추가번역(한글화)할 수 있는 폴더들을 알려주실수 있으십니까?
일례로 vendor폴더 내에 주석을 수정해서 풀리퀘를 보냈더니 k8s 관련이 아니라고 거절 당했습니다.

@gochist
Copy link
Member

gochist commented Nov 4, 2019

@Chihoon-Sung 문서 한글화에 기여와 적극적인 관심 감사드립니다! Slack의 #kubernetes-docs-ko 채널을 통해 질문해주시면 좋겠습니다. https://slack.k8s.io 에서 가입하실 수 있습니다.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/blog Issues or PRs related to the Kubernetes Blog subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/ko Issues or PRs related to Korean language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants