Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change minikube install cmd on macOS #17296

Merged
merged 1 commit into from
Nov 1, 2019
Merged

change minikube install cmd on macOS #17296

merged 1 commit into from
Nov 1, 2019

Conversation

lojies
Copy link
Contributor

@lojies lojies commented Oct 30, 2019

fix #17290 #17260

update page:https://kubernetes.io/docs/tasks/tools/install-minikube/

change command

brew cask install minikube

to

brew install minikube

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 30, 2019
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Oct 30, 2019
@netlify
Copy link

netlify bot commented Oct 30, 2019

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 5f89208

https://deploy-preview-17296--kubernetes-io-master-staging.netlify.com

savitharaghunathan
savitharaghunathan reviewed Oct 30, 2019
View reviewed changes
Copy link
Member

@savitharaghunathan savitharaghunathan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@lojies
Copy link
Contributor Author

lojies commented Nov 1, 2019

@sftim @Rajakavitha1

@bradtopol
Copy link
Contributor

/assign

@bradtopol
Copy link
Contributor

Great catch
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 1, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bradtopol

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 1, 2019
@k8s-ci-robot k8s-ci-robot merged commit e999c03 into kubernetes:master Nov 1, 2019
@savitharaghunathan savitharaghunathan mentioned this pull request Nov 1, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@savitharaghunathan savitharaghunathan savitharaghunathan left review comments

@Rajakavitha1 Rajakavitha1 Awaiting requested review from Rajakavitha1

@sftim sftim Awaiting requested review from sftim

Assignees

@bradtopol bradtopol

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Issue with k8s.io/docs/tasks/tools/install-minikube/
4 participants
@lojies @bradtopol @k8s-ci-robot @savitharaghunathan