modify terminated-pod-gc-threshold explanation (#15272) #17183
Conversation
|
Welcome @hase1128! |
|
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
k8s-ci-robot
added
cncf-cla: no
|
/assign @kbhawkey |
|
Deploy preview for kubernetes-io-master-staging ready! Built with commit 959d99c https://deploy-preview-17183--kubernetes-io-master-staging.netlify.com |
k8s-ci-robot
added
cncf-cla: yes
|
Hello @hase1128 . Thanks for submitting this PR. |
| duration (determined by `terminated-pod-gc-threshold` in the master) will expire and be automatically destroyed. | ||
| this rule is that Pods will be automatically destroyed if the number of Pods | ||
| with a `phase` of Succeeded or Failed surpasses a configurable threshold | ||
| (determined by `terminated-pod-gc-threshold` in the master). |
There was a problem hiding this comment.
@hase1128 , I like the new update -- here is a possible tweak, starting with line 279:
In general, Pods remain until a human or controller process explicitly removes them.
However, Pods will be automatically destroyed if the number of terminated Pods, with a phase of Succeeded or Failed, surpasses a configurable threshold (determined by terminated-pod-gc-threshold in the master).
There was a problem hiding this comment.
My suggestion for the final sentence:
Above a configured number of terminated Pods (with a phase of `Succeeded`
or `Failed`), the control plane cleans up some terminated Pods. This avoids
a resource leak as Pods as created and terminated over time. The clean up
threshold is based on the setting of `terminated-pod-gc-threshold` in the
kube-controller-manager.There was a problem hiding this comment.
@hase1128, do you think you could incorporate @sftim 's suggestion into your PR?
@sftim, your suggestion offers a bit more detail, though, the first sentence seems more complicated.
What about starting the sentence as:
The control plane cleans up terminated Pods (with a ...) when the number of ... exceeds the configured threshold.
Also did you mean,
This avoids a resource leak as Pods are created and terminated over time?
There was a problem hiding this comment.
I incorporate your comments. How about the following explanation?
In general, Pods remain until a human or controller process explicitly removes them.
The control plane cleans up terminated Pods (with a phase of `Succeeded` or
`Failed`), when the number of Pods exceeds the configured threshold
(determined by `terminated-pod-gc-threshold` in the kube-controller-manager).
This avoids a resource leak as Pods are created and terminated over time.
|
Thanks! |
k8s-ci-robot
added
the
lgtm
|
@kbhawkey |
|
/cc @bradtopol |
|
/assign @bradtopol |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bradtopol The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
I modify terminated-pod-gc-threshold explanation
detail information is here.
#15272