Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add content/es/docs/reference/glossary/sig.md #17147

Merged
merged 1 commit into from
Nov 2, 2019
Merged

Add content/es/docs/reference/glossary/sig.md #17147

merged 1 commit into from
Nov 2, 2019

Conversation

andreugallofre
Copy link
Contributor

Add a new page of the glossay :)

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 23, 2019
@k8s-ci-robot k8s-ci-robot added language/es Issues or PRs related to Spanish language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Oct 23, 2019
@andreugallofre
Copy link
Contributor Author

/assign @raelga

@netlify
Copy link

netlify bot commented Oct 23, 2019 •
edited
Loading

Deploy preview for kubernetes-io-master-staging ready!

Built with commit c9c0666

https://deploy-preview-17147--kubernetes-io-master-staging.netlify.com

raelga
raelga requested changes Oct 23, 2019
View reviewed changes
Copy link
Member

@raelga raelga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Muchas gracias @atsuky!

He añadido algunas propuestas en la review, échale un ojo a ver que te parecen.

Un saludo,

content/es/docs/reference/glossary/sig.md Outdated Show resolved Hide resolved
content/es/docs/reference/glossary/sig.md Outdated Show resolved Hide resolved
content/es/docs/reference/glossary/sig.md Outdated Show resolved Hide resolved
content/es/docs/reference/glossary/sig.md Outdated Show resolved Hide resolved
content/es/docs/reference/glossary/sig.md Outdated Show resolved Hide resolved
@andreugallofre
Copy link
Contributor Author

@raelga Suggestions applied, no sabía que había que traducir los "enlaces" a otras referencias del glosario sorry!

He hecho squash de los commits :)

@andreugallofre
Add spanish version of SIG glossary page
c9c0666 
Update content/es/docs/reference/glossary/sig.md

Co-Authored-By: Rael Garcia <[email protected]>

Update content/es/docs/reference/glossary/sig.md

Co-Authored-By: Rael Garcia <[email protected]>

Update content/es/docs/reference/glossary/sig.md

Co-Authored-By: Rael Garcia <[email protected]>

Update content/es/docs/reference/glossary/sig.md

Co-Authored-By: Rael Garcia <[email protected]>

Update content/es/docs/reference/glossary/sig.md

Co-Authored-By: Rael Garcia <[email protected]>

Solve YAML identation errors
@andreugallofre
Copy link
Contributor Author

Revisados los errores de identación en el yaml, ahora si que funciona correctamente

@raelga
Copy link
Member

raelga commented Nov 1, 2019

Muchas gracias por los cambios, por mi parte:

/lgtm

Podéis echarle un vistazo @electrocucaracha o @alexbrand ? :)

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 1, 2019
@alexbrand
Copy link
Contributor

LGTM! Gracias @atsuky

/lgtm

@raelga
Copy link
Member

raelga commented Nov 2, 2019

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: raelga

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 2, 2019
@k8s-ci-robot k8s-ci-robot merged commit 4d20f20 into kubernetes:master Nov 2, 2019
@raelga raelga mentioned this pull request Nov 18, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raelga raelga raelga approved these changes

@alexbrand alexbrand Awaiting requested review from alexbrand

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

Assignees

@alexbrand alexbrand

@raelga raelga

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/es Issues or PRs related to Spanish language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@andreugallofre @raelga @alexbrand @k8s-ci-robot