Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PR template's base branch for zh-trans #16952

Merged
merged 2 commits into from
Oct 16, 2019
Merged

Update PR template's base branch for zh-trans #16952

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dd53833
Update PR template's base branch for zh-trans
chenrui333 Oct 16, 2019
7138d91
Add #kubernetes-docs-zh slack channel reference
chenrui333 Oct 16, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions .github/PULL_REQUEST_TEMPLATE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,9 @@
> Remember to delete this note before submitting your pull request.
>
> For pull requests on 1.17 Features: set Milestone to 1.17 and Base Branch to dev-1.17
>
> For pull requests on Chinese localization, set Base Branch to release-1.15
>
> For pull requests on Chinese localization, set Base Branch to release-1.16
> Feel free to ask questions in #kubernetes-docs-zh
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It'd be good to provide more info about the channel, for example Feel free to ask questions in the #kubernetes-docs-zh Slack channel on [kubernetes.slack.com](https://kubernetes.slack.com)

>
> For pull requests on Korean Localization: set Base Branch to dev-1.16-ko.\<latest team milestone>
>
Expand Down