Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upgrade ubuntu docker image 14.04 → 18.04 #16926

Merged
merged 1 commit into from
Nov 4, 2019
Merged

upgrade ubuntu docker image 14.04 → 18.04 #16926

merged 1 commit into from
Nov 4, 2019

Conversation

diguage
Copy link
Contributor

@diguage diguage commented Oct 15, 2019 •
edited
Loading

  1. I do the exercise: Coarse Parallel Processing Using a Work Queue - Kubernetes. The 18.04 is OK, but the 14.04 returns an error message: logging in to AMQP server: a socket error occurred.
  2. In the Coarse Parallel Processing Using a Work Queue - Kubernetes, the 18.04 is used in the content. So, I think it is best to be consistent.
  3. The 14.04 exceeds the support time.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 15, 2019
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language language/ja Issues or PRs related to Japanese language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Oct 15, 2019
@netlify
Copy link

netlify bot commented Oct 15, 2019

Deploy preview for kubernetes-io-master-staging ready!

Built with commit fc63255

https://deploy-preview-16926--kubernetes-io-master-staging.netlify.com

@makocchi-git
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 15, 2019
@inductor
Copy link
Member

/assign @zacharysarah

@zacharysarah
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zacharysarah

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 4, 2019
@k8s-ci-robot k8s-ci-robot merged commit 9d21f9c into kubernetes:master Nov 4, 2019
@diguage diguage deleted the upgrade-ubuntu branch November 6, 2019 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@makocchi-git makocchi-git Awaiting requested review from makocchi-git

@sftim sftim Awaiting requested review from sftim

Assignees

@makocchi-git makocchi-git

@zacharysarah zacharysarah

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language language/ja Issues or PRs related to Japanese language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@diguage @makocchi-git @inductor @zacharysarah @k8s-ci-robot