Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Edit link in document for issue #16908 #16909

Merged
merged 2 commits into from
Oct 31, 2019
Merged

Edit link in document for issue #16908 #16909

merged 2 commits into from
Oct 31, 2019

Conversation

ysyukr
Copy link
Member

@ysyukr ysyukr commented Oct 15, 2019

Change from full url to inline url.

from #16908
/language en

@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 15, 2019
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Oct 15, 2019
@netlify
Copy link

netlify bot commented Oct 15, 2019 •
edited
Loading

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 5572e62

https://deploy-preview-16909--kubernetes-io-master-staging.netlify.com

@ysyukr ysyukr mentioned this pull request Oct 21, 2019
Merged
18 tasks
@ysyukr ysyukr changed the title Edit link in document. Edit link in document for issue #16908 Oct 27, 2019
@bradtopol
Copy link
Contributor

/assign

@bradtopol
Copy link
Contributor

/assign

@bradtopol
Copy link
Contributor

Great job! Verified that new link works!
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 31, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bradtopol

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 31, 2019
@k8s-ci-robot k8s-ci-robot merged commit 1e4eb26 into kubernetes:master Oct 31, 2019
@ysyukr ysyukr deleted the urlfix-16908 branch November 11, 2019 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caesarxuchao caesarxuchao Awaiting requested review from caesarxuchao

@dchen1107 dchen1107 Awaiting requested review from dchen1107

Assignees

@bradtopol bradtopol

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ysyukr @bradtopol @k8s-ci-robot