Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove OutOfDisk from node condition #16879

Merged
merged 1 commit into from
Nov 13, 2019

Conversation

lojies
Copy link
Contributor

@lojies lojies commented Oct 14, 2019

OutOfDisk is no longer in node contidtion.Remove it from the doc.

@k8s-ci-robot
Copy link
Contributor

Welcome @lojies!

It looks like this is your first PR to kubernetes/website 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/website has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 14, 2019
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Oct 14, 2019
@netlify
Copy link

netlify bot commented Oct 14, 2019

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 96ea536

https://deploy-preview-16879--kubernetes-io-master-staging.netlify.com

@zparnold
Copy link
Member

@lojies What version of Kubernetes did this go live?

@lojies
Copy link
Contributor Author

lojies commented Oct 15, 2019

@lojies What version of Kubernetes did this go live?

This is the changelog from 1.16

  • The deprecated node condition type OutOfDisk has been removed. Use the DiskPressure condition instead. (#72420, @Pingan2017)

@lojies
Copy link
Contributor Author

lojies commented Oct 16, 2019

/assign @stewart-yu

@lojies
Copy link
Contributor Author

lojies commented Oct 18, 2019

/assign @sftim

@lojies
Copy link
Contributor Author

lojies commented Oct 24, 2019

@dchen1107 @caesarxuchao

@sftim sftim removed their assignment Oct 27, 2019
@sftim
Copy link
Contributor

sftim commented Nov 9, 2019

/cc
/lgtm

@k8s-ci-robot k8s-ci-robot requested a review from sftim November 9, 2019 15:07
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 9, 2019
@tfogo
Copy link
Contributor

tfogo commented Nov 13, 2019

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tfogo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 13, 2019
@k8s-ci-robot k8s-ci-robot merged commit cb5153f into kubernetes:master Nov 13, 2019
neolit123 pushed a commit to neolit123/website that referenced this pull request Nov 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants