-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
minikube 1.31 fix for generator to avoid issue #16395
Conversation
with no generator pod was not created
Welcome @dzmitry-lahoda! |
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Deploy preview for kubernetes-io-master-staging ready! Built with commit 48ccb3d https://deploy-preview-16395--kubernetes-io-master-staging.netlify.com |
I signed it |
sorry, i am overwhelmed. i have no rights to add labels or assign somebody. i have signed CLA so. i am in read throughout k8s docs and learn. i hope to send more useful updates to make entrance intko k8s as simple as possible with no error message and deprecation warnings. |
/check-cla |
@dzmitry-lahoda 👋 Welcome to Kubernetes. Sorry you've had a difficult time with your first PR! Thanks for signing the CLA. It looks like this PR now has merge conflicts that need to be resolved in order to proceed. |
Hi @dzmitry-lahoda - thanks for your pull request! The reason you are seeing a merge conflict is because line 56 was changed 14 days ago (see PR #16533 ). The /close |
@aimeeu: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
with no generator pod was not created