-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added a Recycler Pod Template Example #1636
Added a Recycler Pod Template Example #1636
Conversation
Documentation is good. However, I'm not sure if we want to add more documentation, in this case, for the recycle retention policy, considering we want to deprecate it. CC @kubernetes/sig-storage |
I know that the recycle retention policy should be deprecated, however, I don't know when it should be deprecated. Is there a plan when it will be deprecated and when it will be removed from source code? |
|
I think it makes sense to document existing behavior with some note that dynamic provisioning is much better option and recyler should be used only when it's absolutely necessary. |
I've re-opened a PR to add a deprecation statement for recycler. Saad - can we merge this for 1.5? It's non functional and will start the count-down clock for recycler. |
Fine from a Docs perspective. Can somebody give it a tech LGTM? |
Ack. @childsb could you do the tech review for this PR. |
tech lgtm |
@pospispa, please rebase |
03f19dd
to
cdd6bbe
Compare
Recycle pod template example is missing in the documentation. That's why it is now added.
cdd6bbe
to
d4b9023
Compare
* [Spanish] Localize Microservices Architecture * fixes state * Fixes language for preview video and spellcheck. * Adds verified word to dictionary * Adds correct question marks. * Update content/es/microservices-architecture.md Signed-off-by: Mo Figueroa <[email protected]> Co-authored-by: Carol Valencia <[email protected]> Co-authored-by: Victor Morales <[email protected]>
Recycle pod template example is missing in the documentation.
That's why it is now added.
Related Trello card: https://trello.com/c/WhCK1Ndv/86-5-add-checks-and-documentation-about-template-pods-for-recycling
Related source code pull request: kubernetes/kubernetes#36221
cc: @jsafrane
This change is