Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a Recycler Pod Template Example #1636

Conversation

pospispa
Copy link

@pospispa pospispa commented Nov 7, 2016

Recycle pod template example is missing in the documentation.

That's why it is now added.

Related Trello card: https://trello.com/c/WhCK1Ndv/86-5-add-checks-and-documentation-about-template-pods-for-recycling
Related source code pull request: kubernetes/kubernetes#36221

cc: @jsafrane


This change is Reviewable

@saad-ali
Copy link
Member

saad-ali commented Nov 7, 2016

Documentation is good. However, I'm not sure if we want to add more documentation, in this case, for the recycle retention policy, considering we want to deprecate it.

CC @kubernetes/sig-storage

@pospispa
Copy link
Author

pospispa commented Nov 8, 2016

I know that the recycle retention policy should be deprecated, however, I don't know when it should be deprecated. Is there a plan when it will be deprecated and when it will be removed from source code?

@saad-ali
Copy link
Member

Is there a plan when it will be deprecated and when it will be removed from source code?

@childsb @wattsteve?

@jsafrane
Copy link
Member

I think it makes sense to document existing behavior with some note that dynamic provisioning is much better option and recyler should be used only when it's absolutely necessary.

@childsb
Copy link

childsb commented Nov 14, 2016

I've re-opened a PR to add a deprecation statement for recycler.

Saad - can we merge this for 1.5? It's non functional and will start the count-down clock for recycler.

kubernetes/kubernetes#36760

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 21, 2016
@devin-donnelly
Copy link
Contributor

Fine from a Docs perspective. Can somebody give it a tech LGTM?

@jsafrane?

@saad-ali
Copy link
Member

I've re-opened a PR to add a deprecation statement for recycler.

Saad - can we merge this for 1.5? It's non functional and will start the count-down clock for recycler.

kubernetes/kubernetes#36760

Ack. @childsb could you do the tech review for this PR.

@jsafrane
Copy link
Member

tech lgtm

@jsafrane
Copy link
Member

@pospispa, please rebase

@pospispa pospispa force-pushed the 86-5-add-checks-and-documentation-about-template-pods-for-recycling branch from 03f19dd to cdd6bbe Compare November 22, 2016 09:53
Recycle pod template example is missing in the documentation.

That's why it is now added.
@pospispa pospispa force-pushed the 86-5-add-checks-and-documentation-about-template-pods-for-recycling branch from cdd6bbe to d4b9023 Compare November 25, 2016 19:25
@devin-donnelly devin-donnelly merged commit 00b8dca into kubernetes:master Dec 22, 2016
Okabe-Junya pushed a commit to Okabe-Junya/website that referenced this pull request Dec 4, 2023
* [Spanish] Localize Microservices Architecture
* fixes state
* Fixes language for preview video and spellcheck.
* Adds verified word to dictionary
* Adds correct question marks.
* Update content/es/microservices-architecture.md

Signed-off-by: Mo Figueroa <[email protected]>
Co-authored-by: Carol Valencia <[email protected]>
Co-authored-by: Victor Morales <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants