-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document: how to install/distribute plugins with Krew #16322
Conversation
@ahmetb: GitHub didn't allow me to request PR reviews from the following users: corneliusweig. Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Deploy preview for kubernetes-io-master-staging ready! Built with commit 45b9cad https://deploy-preview-16322--kubernetes-io-master-staging.netlify.com |
Deploy preview for kubernetes-io-master-staging ready! Built with commit 33c8be4 https://deploy-preview-16322--kubernetes-io-master-staging.netlify.com |
The md links to krew and krew-index seem to be broken in some places (not all). See https://deploy-preview-16322--kubernetes-io-master-staging.netlify.com/docs/tasks/extend-kubectl/kubectl-plugins/#installing-kubectl-plugins. Maybe it would be better to always inline the link location? Also, it might be worth adding another reference to |
Yeah clearly the markdown engine is broken or performing sub-optimally here. |
Context: Krew (https://sigs.k8s.io/krew) is a Kubernetes SIG CLI sub-project that's been available for over a year. It is considered to be the de-facto tool to discover and install kubectl plugins. This patch details: - how to use Krew to discover/install plugins - how to distribute a kubectl plugin (with traditional package managers or using Krew). Signed-off-by: Ahmet Alp Balkan <[email protected]>
/milestone 1.16 |
@corneliusweig: You must be a member of the kubernetes/website-milestone-maintainers GitHub team to set the milestone. If you believe you should be able to issue the /milestone command, please contact your Website milestone maintainers and have them propose you as an additional delegate for this responsibility. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/milestone 1.16 |
@ahmetb: You must be a member of the kubernetes/website-milestone-maintainers GitHub team to set the milestone. If you believe you should be able to issue the /milestone command, please contact your Website milestone maintainers and have them propose you as an additional delegate for this responsibility. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign @zparnold |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some informal feedback
@ahmetb 👋 What's the status of this PR? |
Sorry I realized my notifications were turned off for the repo. |
Signed-off-by: Ahmet Alp Balkan <[email protected]>
@sftim appreciate the review, I just pushed some fixes. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: zparnold The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Context: Krew (https://sigs.k8s.io/krew) is a Kubernetes SIG CLI sub-project
that's been available for over a year. It is considered to be the de-facto tool
to discover and install kubectl plugins.
This patch details:
using Krew).
/sig cli
/sig docs
/cc @corneliusweig