Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some misspelling on document #16265

Merged
merged 1 commit into from
Sep 11, 2019
Merged

Conversation

slaysd
Copy link

@slaysd slaysd commented Sep 9, 2019

No description provided.

@k8s-ci-robot
Copy link
Contributor

Welcome @jinh574!

It looks like this is your first PR to kubernetes/website 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/website has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
  • If you have done the above and are still having issues with the CLA being reported as unsigned, please log a ticket with the Linux Foundation Helpdesk: https://support.linuxfoundation.org/
  • Should you encounter any issues with the Linux Foundation Helpdesk, send a message to the backup e-mail support address at: [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 9, 2019
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language language/fr Issues or PRs related to French language language/ja Issues or PRs related to Japanese language language/ko Issues or PRs related to Korean language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Sep 9, 2019
@slaysd
Copy link
Author

slaysd commented Sep 9, 2019

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
  • If you have done the above and are still having issues with the CLA being reported as unsigned, please log a ticket with the Linux Foundation Helpdesk: https://support.linuxfoundation.org/
  • Should you encounter any issues with the Linux Foundation Helpdesk, send a message to the backup e-mail support address at: [email protected]

I have sign up now

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Sep 9, 2019
@netlify
Copy link

netlify bot commented Sep 9, 2019

Deploy preview for k8s-dev-ko ready!

Built with commit 4dd6301

https://deploy-preview-16265--k8s-dev-ko.netlify.com

@gochist
Copy link
Member

gochist commented Sep 10, 2019

@jinh574 Thank you for this PR! It looks like that this PR contains unexpected commits. Could you please rebase this PR to have only your commits in the Korean content?

Copy link
Contributor

@jaypipes jaypipes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please submit each of the commits using separate PRs.

The change to the gardener.cloud reference should be a separate PR.

The additional French-language docs should be a separate PR.

And each of the Japanese and Korean-language changes should be submitted as separate PRs.

Thanks!
-jay

content/en/docs/setup/_index.md Outdated Show resolved Hide resolved
@slaysd slaysd changed the base branch from dev-1.15-ko.6 to master September 11, 2019 05:08
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 11, 2019
@slaysd slaysd changed the base branch from master to dev-1.15-ko.6 September 11, 2019 05:10
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 11, 2019
Squashed commits:
[d8172ee] Fix some misspelling on document

Fix misspelling `쿠버네티스는는` => `쿠버네티스는`
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 11, 2019
@slaysd
Copy link
Author

slaysd commented Sep 11, 2019

@gnufied @jaypipes

@jinh574 Thank you for this PR! It looks like that this PR contains unexpected commits. Could you please rebase this PR to have only your commits in the Korean content?

I have solved my PR, maybe I think it caused by jinh574:patch-1 PR base from master. and squash my commit too
thanks

@gochist
Copy link
Member

gochist commented Sep 11, 2019

/remove-language en
/remove-language fr
/remove-language ja

@k8s-ci-robot k8s-ci-robot removed language/en Issues or PRs related to English language language/fr Issues or PRs related to French language language/ja Issues or PRs related to Japanese language labels Sep 11, 2019
@gochist
Copy link
Member

gochist commented Sep 11, 2019

@jinh574 감사합니다!
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 11, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gochist

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 11, 2019
@k8s-ci-robot k8s-ci-robot merged commit 2c11d32 into kubernetes:dev-1.15-ko.6 Sep 11, 2019
gochist added a commit that referenced this pull request Sep 26, 2019
* Remove duplicated sentence (+1 squashed commit) (#16265)
* Fix links to locate Korean docs (#16289)
* Fix typo (#16304)
* Modify #16364 and links in korean docs. (#16516)
* Updated outdated content in `dev-1.15-ko.6` (#16500)
* Modify #16415, #16417 korean docs. (#16501)

Co-Authored-By: 한지승 <[email protected]>
Co-Authored-By: June Yi <[email protected]>
k8s-ci-robot pushed a commit that referenced this pull request Sep 26, 2019
* Remove duplicated sentence (+1 squashed commit) (#16265)
* Fix links to locate Korean docs (#16289)
* Fix typo (#16304)
* Modify #16364 and links in korean docs. (#16516)
* Updated outdated content in `dev-1.15-ko.6` (#16500)
* Modify #16415, #16417 korean docs. (#16501)

Co-Authored-By: 한지승 <[email protected]>
Co-Authored-By: June Yi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/ko Issues or PRs related to Korean language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants