-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes bootstrap js ref to 4.3.1 for API v1.15 #16263
Conversation
Welcome @ahlinc! |
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Deploy preview for kubernetes-io-master-staging ready! Built with commit ce039e7 https://deploy-preview-16263--kubernetes-io-master-staging.netlify.com |
A fix for the v1.15 API version was missed in the kubernetes#14775 PR because the dev-1.15 branch was forked from the master branch before the fix and has been merged back to the master after it.
/assign @tfogo |
/cc @Bradamant3 @jimangel @kbarnard10 @pwittrock @steveperry-53 @tengqm @zacharysarah @zparnold Could someone review, merge and deploy this fix because it's related to the API reference for the latest v1.15 k8s version and fixes broken example buttons on the API page? |
@zacharysarah thank you for looking to this PR. As I found upstream already is totally fine and only this specific already generated page requires direct fix in the same way as it was done in mentioned #14775 PR. Please correct me if I'm wrong, as I found version specific API references placed in a static/docs/reference/generated/kubernetes-api folder are stored in pregenerated form so there is no impact on them from upstream changes and the generation process just copies versioned API reference folders from a |
@ahlinc Sounds good to me. Thanks for the explanation. /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: zacharysarah The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@zacharysarah Awesome, thank you, now the page works correctly. |
A fix for the v1.15 API version was missed in the kubernetes#14775 PR because the dev-1.15 branch was forked from the master branch before the fix and has been merged back to the master after it.
A fix for the v1.15 API version was missed in the #14775 PR
because the dev-1.15 branch was forked from the master branch
before the fix and has been merged back to the master after it.