Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding review changes from PR 15604 #16237

Merged
merged 3 commits into from
Oct 14, 2019
Merged

Adding review changes from PR 15604 #16237

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5abf543
adding review changes from PR 15604
savitharaghunathan Sep 5, 2019
eeb06b1
adding review changes
savitharaghunathan Oct 7, 2019
fde6aa5
adding review changes
savitharaghunathan Oct 8, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 17 additions & 10 deletions content/en/docs/concepts/storage/storage-classes.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,16 +121,23 @@ allows the users to resize the volume by editing the corresponding PVC object.
The following types of volumes support volume expansion, when the underlying
Storage Class has the field `allowVolumeExpansion` set to true.

* gcePersistentDisk
* awsElasticBlockStore
* Cinder
* glusterfs
* rbd
* Azure File
* Azure Disk
* Portworx
* FlexVolumes
* CSI {{< feature-state for_k8s_version="v1.14" state="alpha" >}}
{{< table caption = "Table of Volume types and the version of Kubernetes they require" >}}

Volume type | Required Kubernetes version
:---------- | :--------------------------
gcePersistentDisk | 1.11
awsElasticBlockStore | 1.11
Cinder | 1.11
glusterfs | 1.11
rbd | 1.11
Azure File | 1.11
Azure Disk | 1.11
Portworx | 1.11
FlexVolumes | 1.13
savitharaghunathan marked this conversation as resolved.
Show resolved Hide resolved
CSI | 1.14 ,1.15-alpha ,1.16-beta
savitharaghunathan marked this conversation as resolved.
Show resolved Hide resolved
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
CSI | 1.14 ,1.15-alpha ,1.16-beta
CSI | 1.14 (alpha), 1.16 (beta)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks much better. Thanks for the suggestion, @sftim . I will make the changes by EOD and resubmit for review

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you mean CSI | 1.14 ,1.15 (alpha) ,1.16 (beta) instead of CSI | 1.14 (alpha), 1.16 (beta) ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To me it's clear / obvious that something that goes alpha in v1.14 is and beta in v1.16 is also alpha in v1.15

Maybe that's not clear to all readers.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the clarification, Tim. I wasn't aware of that before. I have made the changes you suggested. If it all looks good, I will squash the commits into one.


{{< /table >}}


{{< note >}}
This feature cannot be used to shrink volumes.
savitharaghunathan marked this conversation as resolved.
Show resolved Hide resolved
Expand Down