Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: typo in assign-pods-nodes.md (Chinese version) #16170

Merged
merged 2 commits into from
Sep 6, 2019

Conversation

chendotjs
Copy link
Contributor

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/zh Issues or PRs related to Chinese language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 31, 2019
@chendotjs
Copy link
Contributor Author

/assign @xichengliudui

@xichengliudui
Copy link
Contributor

@chendotjs , Thanks for the fix, but please fix the rest of this article.
/lgtm
/approve
/hold
Please tell me the preview link...

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 31, 2019
@xichengliudui
Copy link
Contributor

eg:
image

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 1, 2019
@chendotjs
Copy link
Contributor Author

chendotjs commented Sep 1, 2019

The rest is fixed. This is the preview link.

/assign @xichengliudui

@chendotjs
Copy link
Contributor Author

/assign @zhangxiaoyu-zidif

@xichengliudui
Copy link
Contributor

/lgtm
thanks

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 2, 2019
@xichengliudui
Copy link
Contributor

/approve

1 similar comment
@xichengliudui
Copy link
Contributor

/approve

@chendotjs
Copy link
Contributor Author

chendotjs commented Sep 6, 2019

/assign @zhangxiaoyu-zidif
/assign @chenrui333

PTAL, thanks

@zhangxiaoyu-zidif
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xichengliudui, zhangxiaoyu-zidif

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 6, 2019
@chendotjs
Copy link
Contributor Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 6, 2019
@k8s-ci-robot k8s-ci-robot merged commit fb3f734 into kubernetes:release-1.14 Sep 6, 2019
SataQiu pushed a commit to SataQiu/website that referenced this pull request Oct 9, 2019
* Fix: typo in assign-pods-nodes.md (Chinese version)

* Add version check in zh.toml (Chinese version)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/zh Issues or PRs related to Chinese language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants