Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translate Pod Lifecycle to Bahasa Indonesia #16165

Merged
merged 4 commits into from
Sep 3, 2019
Merged

Translate Pod Lifecycle to Bahasa Indonesia #16165

merged 4 commits into from
Sep 3, 2019

Conversation

wahyuoi
Copy link
Contributor

@wahyuoi wahyuoi commented Aug 31, 2019

Addresses #15341
/assign @irvifa

@k8s-ci-robot
Copy link
Contributor

Welcome @wahyuoi!

It looks like this is your first PR to kubernetes/website 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/website has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 31, 2019
@k8s-ci-robot k8s-ci-robot added language/id Issues or PRs related to Indonesian language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Aug 31, 2019
@netlify
Copy link

netlify bot commented Aug 31, 2019 •
edited
Loading

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 75a11b8

https://deploy-preview-16165--kubernetes-io-master-staging.netlify.com

irvifa
irvifa suggested changes Sep 2, 2019
View reviewed changes
content/id/docs/concepts/workloads/pods/pod-lifecycle.md Outdated Show resolved Hide resolved
content/id/docs/concepts/workloads/pods/pod-lifecycle.md Outdated Show resolved Hide resolved
content/id/docs/concepts/workloads/pods/pod-lifecycle.md Outdated Show resolved Hide resolved
content/id/docs/concepts/workloads/pods/pod-lifecycle.md Outdated Show resolved Hide resolved
content/id/docs/concepts/workloads/pods/pod-lifecycle.md Outdated Show resolved Hide resolved
content/id/docs/concepts/workloads/pods/pod-lifecycle.md Outdated Show resolved Hide resolved
content/id/docs/concepts/workloads/pods/pod-lifecycle.md Outdated Show resolved Hide resolved
content/id/docs/concepts/workloads/pods/pod-lifecycle.md Outdated Show resolved Hide resolved
content/id/docs/concepts/workloads/pods/pod-lifecycle.md Outdated Show resolved Hide resolved
content/id/docs/concepts/workloads/pods/pod-lifecycle.md Outdated Show resolved Hide resolved
irvifa
irvifa suggested changes Sep 3, 2019
View reviewed changes
Copy link
Member

@irvifa irvifa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your effort in kubernetes translations for ID localization 🎉 I only have one more feedback, once it's addressed it's should be good for me.

content/id/docs/concepts/workloads/pods/pod-lifecycle.md Outdated Show resolved Hide resolved
@irvifa
Copy link
Member

irvifa commented Sep 3, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 3, 2019
@irvifa
Copy link
Member

irvifa commented Sep 3, 2019

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: irvifa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 3, 2019
@irvifa
Copy link
Member

irvifa commented Sep 3, 2019

Merged 🎉 thanks a lot!

@k8s-ci-robot k8s-ci-robot merged commit 9e3e30b into kubernetes:master Sep 3, 2019
@wahyuoi
Copy link
Contributor Author

wahyuoi commented Sep 3, 2019

Thanks @irvifa 🙇‍♂️

@wahyuoi wahyuoi deleted the id-pod-lifecycle branch September 3, 2019 12:05
wahyuoi added a commit to wahyuoi/website that referenced this pull request Sep 9, 2019
@wahyuoi @irvifa
Translate Pod Lifecycle to Bahasa Indonesia (kubernetes#16165)
6892e0d 
* translation to bahasa indonesia

* Apply suggestions from code review

Co-Authored-By: Irvi Aini <[email protected]>

* tidy up some words

* Apply suggestions from code review

Co-Authored-By: Irvi Aini <[email protected]>
@girikuncoro girikuncoro mentioned this pull request Sep 29, 2019
Closed
45 tasks
@wahyuoi wahyuoi mentioned this pull request Jan 10, 2020
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@irvifa irvifa irvifa requested changes

@girikuncoro girikuncoro Awaiting requested review from girikuncoro

Assignees

@irvifa irvifa

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/id Issues or PRs related to Indonesian language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wahyuoi @k8s-ci-robot @irvifa