Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate concepts/workloads/controllers/deployment.md in Korean #16113

Merged
merged 7 commits into from
Sep 5, 2019
Merged

Translate concepts/workloads/controllers/deployment.md in Korean #16113

merged 7 commits into from
Sep 5, 2019

Conversation

ysyukr
Copy link
Member

@ysyukr ysyukr commented Aug 28, 2019

from #16023
/language ko

다른 PR에서 의견주셨던 부분을 최대한 반영해서 번역을 진행했습니다.
다만, 일부 용어에 대한 부분을 임의적으로 번역을 진행했으며, 용어집 하단에 용어 등록을 위해 기록해두었습니다.

@k8s-ci-robot k8s-ci-robot added language/ko Issues or PRs related to Korean language cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Aug 28, 2019
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Aug 28, 2019
@netlify
Copy link

netlify bot commented Aug 28, 2019

Deploy preview for k8s-dev-ko ready!

Built with commit cc12af9

https://deploy-preview-16113--k8s-dev-ko.netlify.com

@netlify
Copy link

netlify bot commented Aug 28, 2019

Deploy preview for k8s-dev-ko ready!

Built with commit e085c7e

https://deploy-preview-16113--k8s-dev-ko.netlify.com

@seokho-son
Copy link
Member

/assign @seokho-son

Copy link
Member

@seokho-son seokho-son left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ysyukr 컨트리뷰션 감사합니다. 장문의 문서가 하나 더 번역되었네요.. 👍
우선, 288 라인까지 리뷰 완료하였습니다. 의견 참고하셔서 업데이트 부탁드립니다.

@ysyukr
Copy link
Member Author

ysyukr commented Sep 5, 2019

@seokho-son 리뷰 감사합니다.
제안해주신 부분에 대해 확인 및 반영했습니다.
또한, 용어의 띄어쓰기와 일부 번역 누락 및 부자연스러운 부분을 일부 수정했습니다.

Copy link
Member

@seokho-son seokho-son left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ysyukr
문서를 전체적으로 검토 완료하였습니다. 의견 참고하셔서 업데이트 부탁드립니다 :)
의견은 참고 사항으로 이해해주시면 될 것 같습니다. 혹시라도 다르게 생각되시는 부분이 있으면 공유해주세요.. :)

@ysyukr
Copy link
Member Author

ysyukr commented Sep 5, 2019

@seokho-son 님, 리뷰 감사합니다.
제안해주신 부분 전부 확인하여 반영을 진행했습니다.
또한, 링크가 유실된 부분에 대해서는 링크가 연결되도록 설정했으며, 일부 불필요한 괄호문에 대해서는 제거했습니다.

@seokho-son
Copy link
Member

@ysyukr 감사합니다 !
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 5, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: seokho-son

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 5, 2019
@k8s-ci-robot k8s-ci-robot merged commit e801fe0 into kubernetes:dev-1.15-ko.5 Sep 5, 2019
seokho-son added a commit that referenced this pull request Sep 5, 2019
* Translate `concepts/scheduling/_index.md` to Korean (#16072)
* Translate concepts/workloads/controllers/replicaset.md in Korean (#16070)
* Update outdated content in dev-1.15-ko.5 (#16162)
* Translate using-api/client-libraries into korean (#16182)
* ko: translate concepts/cluster-administration/proxies (#16030)
* Translate concepts/workloads/controllers/deployment.md in Korean (#16113)

Co-Authored-By: Seokho Son <[email protected]>
Co-Authored-By: Eden <[email protected]>
Co-Authored-By: Yoon <[email protected]>
Co-Authored-By: Sunghoon Kang <[email protected]>
Co-Authored-By: Yuk, Yongsu <[email protected]>
Co-Authored-By: June Yi <[email protected]>
@ysyukr ysyukr deleted the deployment-ko branch September 6, 2019 00:27
k8s-ci-robot pushed a commit that referenced this pull request Sep 6, 2019
* Translate `concepts/scheduling/_index.md` to Korean (#16072)
* Translate concepts/workloads/controllers/replicaset.md in Korean (#16070)
* Update outdated content in dev-1.15-ko.5 (#16162)
* Translate using-api/client-libraries into korean (#16182)
* ko: translate concepts/cluster-administration/proxies (#16030)
* Translate concepts/workloads/controllers/deployment.md in Korean (#16113)

Co-Authored-By: Seokho Son <[email protected]>
Co-Authored-By: Eden <[email protected]>
Co-Authored-By: Yoon <[email protected]>
Co-Authored-By: Sunghoon Kang <[email protected]>
Co-Authored-By: Yuk, Yongsu <[email protected]>
Co-Authored-By: June Yi <[email protected]>
wahyuoi pushed a commit to wahyuoi/website that referenced this pull request Sep 9, 2019
* Translate `concepts/scheduling/_index.md` to Korean (kubernetes#16072)
* Translate concepts/workloads/controllers/replicaset.md in Korean (kubernetes#16070)
* Update outdated content in dev-1.15-ko.5 (kubernetes#16162)
* Translate using-api/client-libraries into korean (kubernetes#16182)
* ko: translate concepts/cluster-administration/proxies (kubernetes#16030)
* Translate concepts/workloads/controllers/deployment.md in Korean (kubernetes#16113)

Co-Authored-By: Seokho Son <[email protected]>
Co-Authored-By: Eden <[email protected]>
Co-Authored-By: Yoon <[email protected]>
Co-Authored-By: Sunghoon Kang <[email protected]>
Co-Authored-By: Yuk, Yongsu <[email protected]>
Co-Authored-By: June Yi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/ko Issues or PRs related to Korean language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants