Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split Falco audit example into own page #16011

Merged
merged 1 commit into from
Aug 23, 2019
Merged

Split Falco audit example into own page #16011

merged 1 commit into from
Aug 23, 2019

Conversation

mcbenjemaa
Copy link
Member

Fixes #15963

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 22, 2019
@mcbenjemaa
Copy link
Member Author

/assign @makoscafee

@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Aug 22, 2019
@netlify
Copy link

netlify bot commented Aug 22, 2019 •
edited
Loading

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 397c645

https://deploy-preview-16011--kubernetes-io-master-staging.netlify.com

sftim
sftim reviewed Aug 22, 2019
View reviewed changes
content/en/docs/tasks/debug-application-cluster/audit.md Outdated
[falco_ka_docs]: https://falco.org/docs/event-sources/kubernetes-audit
[falco_installation]: https://falco.org/docs/installation
[falco_helm_chart]: https://github.com/helm/charts/tree/master/stable/falco
[Use Falco to collect audit events](/docs/tasks/debug-application-cluster/falco)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I recommend creating a new whatsnext section, similar to https://github.com/kubernetes/website/blame/9f1d574aa9f5df5f69f63141e96f3ee6daa905e6/content/en/docs/tasks/debug-application-cluster/debug-service.md#L641

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also it's worth matching the title of the link to the target.

sftim
sftim reviewed Aug 22, 2019
View reviewed changes
content/en/docs/tasks/debug-application-cluster/falco.md Outdated
- sttts
- ericchiang
content_template: templates/concept
title: Webhook Collector Examples
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: this title looks wrong.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What would be the title!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about “Auditing with Falco”?

@mcbenjemaa
Copy link
Member Author

ready for merge

@sftim
Copy link
Contributor

sftim commented Aug 23, 2019 •
edited
Loading

/lgtm
Looking at #15892 this change seems OK. It's about doing a Kubernetes thing (cluster audit) using a CNCF project to help with that.

“Adding content for kubernetes or kubernetes-sigs projects that don't have their own instructional content”

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 23, 2019
@makoscafee
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: makoscafee

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 23, 2019
@k8s-ci-robot k8s-ci-robot merged commit 92e439e into kubernetes:master Aug 23, 2019
@dvob dvob mentioned this pull request Aug 29, 2019
Closed
dvob added a commit to dvob/kubernetes-website that referenced this pull request Aug 29, 2019
@dvob
Add link references which were removed with kubernetes#16011
eba17e7 
Signed-off-by: David Schneider <[email protected]>
@aimeeu
Copy link
Contributor

aimeeu commented Aug 29, 2019

I know this has already been merged.... but Falco has its own documentation.This content might be better located in the Falco documentation and then linked to from the Kubernetes documentation.

This was referenced Aug 29, 2019
Merged
Closed
k8s-ci-robot pushed a commit that referenced this pull request Aug 30, 2019
@dvob @k8s-ci-robot
Add link references which were removed with #16011 (#16140)
6583710 
* Add link references which were removed with #16011

Signed-off-by: David Schneider <[email protected]>

* Move link references into correct capture block
wahyuoi pushed a commit to wahyuoi/website that referenced this pull request Sep 9, 2019
@mcbenjemaa @wahyuoi
split falco section to a new page (kubernetes#16011)
73d2d1f
wahyuoi pushed a commit to wahyuoi/website that referenced this pull request Sep 9, 2019
@dvob @wahyuoi
Add link references which were removed with kubernetes#16011 (kuberne…
e40fdf9 
…tes#16140)

* Add link references which were removed with kubernetes#16011

Signed-off-by: David Schneider <[email protected]>

* Move link references into correct capture block
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sftim sftim sftim left review comments

@makoscafee makoscafee makoscafee approved these changes

@soltysh soltysh Awaiting requested review from soltysh

@stewart-yu stewart-yu Awaiting requested review from stewart-yu

Assignees

@makoscafee makoscafee

@sftim sftim

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Split Falco audit example into own page
5 participants
@mcbenjemaa @sftim @makoscafee @k8s-ci-robot @aimeeu