Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Etiquette for requesting PR reviews #15972

Merged
merged 1 commit into from
Aug 21, 2019
Merged

Etiquette for requesting PR reviews #15972

merged 1 commit into from
Aug 21, 2019

Conversation

savitharaghunathan
Copy link
Member

This PR is a follow up on the discussion that happened in sig-docs meeting earlier today. It is about the process and etiquette for requesting reviewers to review the changes.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 20, 2019
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Aug 20, 2019
@netlify
Copy link

netlify bot commented Aug 20, 2019

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 2e28aef

https://deploy-preview-15972--kubernetes-io-master-staging.netlify.com

@netlify
Copy link

netlify bot commented Aug 20, 2019

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 0206696

https://deploy-preview-15972--kubernetes-io-master-staging.netlify.com

@savitharaghunathan
Copy link
Member Author

/assign @gochist

@gochist
Copy link
Member

gochist commented Aug 21, 2019

@zacharysarah Cloud you please assign another owner for this?

@zacharysarah
Copy link
Contributor

@gochist Sure thing. Feel free to assign whoever is the PR wrangler for the week!

/unassign @gochist
/assign @kbarnard10

@k8s-ci-robot k8s-ci-robot assigned kbarnard10 and unassigned gochist Aug 21, 2019
@kbarnard10
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 21, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kbarnard10

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 21, 2019
@k8s-ci-robot k8s-ci-robot merged commit 8c4a2bf into kubernetes:master Aug 21, 2019
@savitharaghunathan savitharaghunathan deleted the reviewrequestetiquette branch September 2, 2019 20:29
wahyuoi pushed a commit to wahyuoi/website that referenced this pull request Sep 9, 2019
@savitharaghunathan @wahyuoi
Adding PR review request etiquette (kubernetes#15972)
a725f3c
@savitharaghunathan savitharaghunathan mentioned this pull request Sep 25, 2019
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rajakavitha1 Rajakavitha1 Awaiting requested review from Rajakavitha1

@zhangxiaoyu-zidif zhangxiaoyu-zidif Awaiting requested review from zhangxiaoyu-zidif

Assignees

@kbarnard10 kbarnard10

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@savitharaghunathan @gochist @zacharysarah @kbarnard10 @k8s-ci-robot