Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with k8s.io/docs/tutorials/ #15518 #15542

Merged
merged 1 commit into from
Aug 22, 2019

Conversation

mcbenjemaa
Copy link
Member

update sweetAlert and fix scrolling after copy

k8s-new-alert

Fixes #15518

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 26, 2019
@netlify
Copy link

netlify bot commented Jul 26, 2019

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 18b3f87

https://deploy-preview-15542--kubernetes-io-master-staging.netlify.com

@mcbenjemaa
Copy link
Member Author

/assign @kbarnard10

@ryanmcginnis
Copy link
Contributor

seems like this fixes #4205! thanks!

@thecrudge
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 31, 2019
@xiangpengzhao
Copy link
Contributor

/assign @lucperkins
for approval

@k8s-ci-robot
Copy link
Contributor

@xiangpengzhao: GitHub didn't allow me to assign the following users: lucperkins.

Note that only kubernetes members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @lucperkins
for approval

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@xiangpengzhao
Copy link
Contributor

ping @kbarnard10 for approval :)

@kbarnard10
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kbarnard10

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 21, 2019
@k8s-ci-robot k8s-ci-robot merged commit 63eb064 into kubernetes:master Aug 22, 2019
wahyuoi pushed a commit to wahyuoi/website that referenced this pull request Sep 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue with k8s.io/docs/tutorials/
6 participants