Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add zh readme #14773

Merged
merged 15 commits into from
Jun 20, 2019
Merged

fix: add zh readme #14773

merged 15 commits into from
Jun 20, 2019

Conversation

zhangqx2010
Copy link
Contributor

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 7, 2019
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Jun 7, 2019
@zhangqx2010
Copy link
Contributor Author

@tengqm Please take a look. Thanks.

@netlify
Copy link

netlify bot commented Jun 7, 2019 •
edited
Loading

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 8102fcd

https://deploy-preview-14773--kubernetes-io-master-staging.netlify.com

@zhangqx2010 zhangqx2010 mentioned this pull request Jun 7, 2019
Closed
@zhangqx2010
Copy link
Contributor Author

cc @markthink

tengqm
tengqm reviewed Jun 11, 2019
View reviewed changes
README-zh.md Outdated Show resolved Hide resolved
tengqm
tengqm reviewed Jun 11, 2019
View reviewed changes
README-zh.md Outdated Show resolved Hide resolved
@tengqm
Copy link
Contributor

tengqm commented Jun 11, 2019

Looks good in general. Please include the original text in your localized version for change management and review. Thanks.

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 11, 2019
@zhangqx2010
Copy link
Contributor Author

#14562

@zhangqx2010
Copy link
Contributor Author

@tengqm @chenrui333 Please take a look. Thanks.

SataQiu
SataQiu reviewed Jun 13, 2019
View reviewed changes
Copy link
Member

@SataQiu SataQiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

添加一些小建议供参考

README-zh.md Outdated Show resolved Hide resolved
README-zh.md Outdated Show resolved Hide resolved
README-zh.md
<!--
## `README.md`'s Localizing Kubernetes Documentation
-->
## `README.md` 的本地化 Kubernetes 文档
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个标题没有内容，建议删除或补全内容

Copy link
Contributor Author

@zhangqx2010 zhangqx2010 Jun 13, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个我还是保留吧，与所有其他语言文档保持一致

README-zh.md Outdated Show resolved Hide resolved
README-zh.md Outdated Show resolved Hide resolved
README-zh.md Outdated Show resolved Hide resolved
README-zh.md Outdated Show resolved Hide resolved
README-zh.md Outdated Show resolved Hide resolved
README-zh.md Outdated Show resolved Hide resolved
README-zh.md Outdated Show resolved Hide resolved
zhangqx2010 and others added 9 commits June 13, 2019 15:12
@zhangqx2010 @SataQiu
Update README-zh.md
a386c66 
Co-Authored-By: SataQiu <[email protected]>
@zhangqx2010 @SataQiu
Update README-zh.md
e31d627 
Co-Authored-By: SataQiu <[email protected]>
@zhangqx2010 @SataQiu
Update README-zh.md
742e0a2 
Co-Authored-By: SataQiu <[email protected]>
@zhangqx2010 @SataQiu
Update README-zh.md
353e3f3 
Co-Authored-By: SataQiu <[email protected]>
@zhangqx2010 @SataQiu
Update README-zh.md
c2a5ac5 
Co-Authored-By: SataQiu <[email protected]>
@zhangqx2010 @SataQiu
Update README-zh.md
e7ea874 
Co-Authored-By: SataQiu <[email protected]>
@zhangqx2010 @SataQiu
Update README-zh.md
a78ce49 
Co-Authored-By: SataQiu <[email protected]>
@zhangqx2010 @SataQiu
Update README-zh.md
ca055bc 
Co-Authored-By: SataQiu <[email protected]>
@zhangqx2010 @SataQiu
Update README-zh.md
179626d 
Co-Authored-By: SataQiu <[email protected]>
SataQiu
SataQiu reviewed Jun 13, 2019
View reviewed changes
README-zh.md Outdated Show resolved Hide resolved
@zhangqx2010 @SataQiu
Update README-zh.md
b49fab2 
Co-Authored-By: SataQiu <[email protected]>
@SataQiu
Copy link
Member

SataQiu commented Jun 13, 2019

Thanks for your update @zhangqx2010 ! 😊
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 13, 2019
@chenrui333
Copy link
Member

I will take a look later, nice work at first!!

chenrui333
chenrui333 reviewed Jun 14, 2019
View reviewed changes
README-zh.md Outdated Show resolved Hide resolved
chenrui333
chenrui333 reviewed Jun 14, 2019
View reviewed changes
README-zh.md
可以通过以下方式联系中文本地化的维护人员：

* He Xiaolong ([GitHub - @markthink](https://github.com/markthink))
* [Slack channel](https://kubernetes.slack.com/messages/kubernetes-docs-zh)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can also add my info in here too.

Rui Chen ([GitHub - @chenrui333](https://github.com/chenrui333))

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Of course, I did think of that. 😄

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

haha 👍

chenrui333
chenrui333 approved these changes Jun 14, 2019
View reviewed changes
Copy link
Member

@chenrui333 chenrui333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm except few comments and suggestions :)

@zhangqx2010 @chenrui333
Update README-zh.md
bcca784 
Co-Authored-By: chenrui <[email protected]>
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 15, 2019
@zhangqx2010
Copy link
Contributor Author

need lgtm @chenrui333

@chenrui333
Copy link
Member

/lgtm
/approve

Thanks!!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 15, 2019
@chenrui333
Copy link
Member

/assign @kbarnard10

@chenrui333
Copy link
Member

@kbarnard10, It is ready to ship!

@kbarnard10
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chenrui333, kbarnard10

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 20, 2019
@k8s-ci-robot k8s-ci-robot merged commit 2beb323 into kubernetes:master Jun 20, 2019
@zhangqx2010 zhangqx2010 deleted the fix-readme branch June 20, 2019 12:38
joaovitor pushed a commit to joaovitor/website that referenced this pull request Jul 5, 2019
@zhangqx2010 @joaovitor
fix: add zh readme (kubernetes#14773)
8674c94 
* fix: add zh readme

* Update README.md

* add origin english version for veview
fix typo

* Update README-zh.md

Co-Authored-By: SataQiu <[email protected]>

* Update README-zh.md

Co-Authored-By: SataQiu <[email protected]>

* Update README-zh.md

Co-Authored-By: SataQiu <[email protected]>

* Update README-zh.md

Co-Authored-By: SataQiu <[email protected]>

* Update README-zh.md

Co-Authored-By: SataQiu <[email protected]>

* Update README-zh.md

Co-Authored-By: SataQiu <[email protected]>

* Update README-zh.md

Co-Authored-By: SataQiu <[email protected]>

* Update README-zh.md

Co-Authored-By: SataQiu <[email protected]>

* Update README-zh.md

Co-Authored-By: SataQiu <[email protected]>

* Update README-zh.md

Co-Authored-By: SataQiu <[email protected]>

* Update README-zh.md

Co-Authored-By: chenrui <[email protected]>

* Update README-zh.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tengqm tengqm tengqm left review comments

@chenrui333 chenrui333 chenrui333 approved these changes

@SataQiu SataQiu SataQiu approved these changes

@Rajakavitha1 Rajakavitha1 Awaiting requested review from Rajakavitha1

@stewart-yu stewart-yu Awaiting requested review from stewart-yu

Assignees

@chenrui333 chenrui333

@SataQiu SataQiu

@kbarnard10 kbarnard10

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@zhangqx2010 @tengqm @SataQiu @chenrui333 @kbarnard10 @k8s-ci-robot