Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Corrected the relative path #14656

Closed
wants to merge 2 commits into from
Closed

Corrected the relative path #14656

wants to merge 2 commits into from

Conversation

hpandeycodeit
Copy link

@hpandeycodeit hpandeycodeit commented May 31, 2019 •
edited
Loading

Following links are taking to a new page with 403 Error:

Starting a Cluster , Stopping a Cluster and Interacting with Your Cluster

This PR fixes the above links. Related Issue #14623

@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 31, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: kbarnard10

If they are not already assigned, you can assign the PR to them by writing /assign @kbarnard10 in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested review from balopat and dlorenc May 31, 2019 06:43
@netlify
Copy link

netlify bot commented May 31, 2019 •
edited
Loading

Deploy preview for kubernetes-io-master-staging ready!

Built with commit d9770e0

https://deploy-preview-14656--kubernetes-io-master-staging.netlify.com

@hpandeycodeit hpandeycodeit mentioned this pull request May 31, 2019
Closed
poothia
poothia reviewed May 31, 2019
View reviewed changes
Copy link
Contributor

@poothia poothia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please take a look.

@hpandeycodeit
Copy link
Author

please take a look.

@poothia File extension is not needed here. Feel free to check the changes in the staging :

https://deploy-preview-14656--kubernetes-io-master-staging.netlify.com

@poothia
Copy link
Contributor

poothia commented May 31, 2019

please take a look.

@poothia File extension is not needed here. Feel free to check the changes in the staging :

https://deploy-preview-14656--kubernetes-io-master-staging.netlify.com

agreed... but you still need to change it.

you can just change the links as follows:-

docs/setup/minikube/#starting-a-cluster
to
#starting-a-cluster

and likewise.

@Rajakavitha1
Copy link
Contributor

@hpandeycodeit Please resolve the conflicts!!!

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 3, 2019
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 3, 2019
@hpandeycodeit
Copy link
Author

@Rajakavitha1

Looks like this is already fixed as part of this PR: #14662

Feel free to close this one.

Thank you!

@tengqm tengqm closed this Jun 4, 2019
@tddorgtfo
Copy link
Contributor

Fixed #14623

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@poothia poothia poothia left review comments

@balopat balopat Awaiting requested review from balopat

@dlorenc dlorenc Awaiting requested review from dlorenc

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@hpandeycodeit @k8s-ci-robot @poothia @Rajakavitha1 @tddorgtfo @tengqm