Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing Loadbalancer IP from the sample service file #14642

Merged
merged 3 commits into from
Oct 8, 2019
Merged

Removing Loadbalancer IP from the sample service file #14642

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7cb15e9
Update service.md
Abhik1998 May 30, 2019
09456be
Update service.md
Abhik1998 Oct 2, 2019
fea0817
Merge branch 'master' into patch-4
Abhik1998 Oct 2, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion content/en/docs/concepts/services-networking/service.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -439,7 +439,6 @@ spec:
port: 80
targetPort: 9376
clusterIP: 10.0.171.239
loadBalancerIP: 78.11.24.19
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about: also edit 146.148.47.155 (below, as an example of the ingress IP address) to use a documentation IP address?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, its a good idea but for new users , in fact I didn't hear of it before

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay I checked . Actually , 146.148.47.155 is just a sample.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Abhik1998 Indeed. 146.148.47.155 is assigned to Google Cloud whereas (say) 192.0.2.127 is reserved for use in documentation.

Readers who misunderstand might try to connect to 146.148.47.155 and find that it's a real website.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay
got it then should I commit a change
ingressIP: 192.0.2.127

type: LoadBalancer
status:
loadBalancer:
Expand Down