Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move podresources endpoint to beta #14622

Merged
merged 1 commit into from
Jun 6, 2019
Merged

move podresources endpoint to beta #14622

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion content/en/docs/concepts/extend-kubernetes/compute-storage-net/device-plugins.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,7 @@ DaemonSet, `/var/lib/kubelet/pod-resources` must be mounted as a
in the plugin's
[PodSpec](/docs/reference/generated/kubernetes-api/{{< param "version" >}}/#podspec-v1-core).

Support for the "PodResources service" is still in alpha.
Support for the "PodResources service" is in beta, and is enabled by default.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change LGTM. However, I see this Kubernetes device plugin support is still in alpha. in section Device plugin deployment. AFAIK, Kubernetes device plugin support is already in beta from v1.14. See: https://kubernetes.io/docs/concepts/extend-kubernetes/compute-storage-net/device-plugins/

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It sounds like we need to make that change separately, and cherry-pick it to the 1.14 release docs.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It'd be more usual for website docs to make the change in master and not worry about putting the equivalent change into the v1.15 branch

Right now the most recent Kubernetes release is 1.14, so master is documentation for cluster operators running 1.14

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The sentence there in master branch is Kubernetes device plugin support is in beta.
The sentence there in 1.14 release branch is Kubernetes device plugin support is still in alpha.
But the sentence there in the published docs website (which means to show 1.14 release contents) is Kubernetes device plugin support is in beta.
And the sentence there in the forked branch of this PR is Kubernetes device plugin support is still in alpha.

I'm confused... @tengqm any thoughts?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I would check that the latest changes from master are up-to-date in the dev-1.15 branch. I think the change in question happened a few days ago? The dev-1.15 branch should contain the master branch changes plus the new 1.15 content.
/cc @makoscafee

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, @kbhawkey will work to update dev-1.15 with master changes right now .. will let you know when its done.


## Examples

Expand Down