Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix glossary tooltip mismatch #14227

Merged

Conversation

seokho-son
Copy link
Member

To fix #14226. (I found #12608 is related too)

I modified

{{- $term_info := $glossary_items.GetMatch (printf "%s*" $id ) -}}

from not exact match ("%s*") to exact match ("%s.md").

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 8, 2019
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels May 8, 2019
@seokho-son
Copy link
Member Author

seokho-son commented May 8, 2019

We can check the current bug in
https://kubernetes.io/docs/reference/glossary/?all=true#term-app-container
If we mouse over to "containers" and "pod", we can check they show wrong tooltips.

We can check the preview as follows,
https://deploy-preview-14227--kubernetes-io-master-staging.netlify.com/docs/reference/glossary/?workload=true#term-app-container

@netlify
Copy link

netlify bot commented May 8, 2019

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 48deec2

https://deploy-preview-14227--kubernetes-io-master-staging.netlify.com

@kbhawkey
Copy link
Contributor

kbhawkey commented May 8, 2019

Looks good, 👍

@Rajakavitha1
Copy link
Contributor

/language-en

@Rajakavitha1
Copy link
Contributor

/language en

@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label May 8, 2019
@Rajakavitha1
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 8, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Rajakavitha1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 8, 2019
@k8s-ci-robot k8s-ci-robot merged commit 017a224 into kubernetes:master May 8, 2019
yoonian pushed a commit to yoonian/kubernetes-website that referenced this pull request May 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Glossary tooltip mismatch in reference/glossary/
4 participants