Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CPUCFSQuotaPeriod - CLI Reference mismatch #14090

Merged
merged 1 commit into from
Apr 30, 2019
Merged

CPUCFSQuotaPeriod - CLI Reference mismatch #14090

merged 1 commit into from
Apr 30, 2019

Conversation

karlskewes
Copy link
Contributor

@karlskewes karlskewes commented Apr 28, 2019 •
edited
Loading

Page: https://kubernetes.io/docs/reference/command-line-tools-reference/feature-gates/

CPUCFSQuotaPeriod Feature Gate is set from the flag name CustomCPUCFSQuotaPeriod per kube_features.go#163
This PR updates the docs to suit.

In some respects it would be tidier to remove Custom prefix from kube_features.go so that the Feature Gate naming maps 1:1 as per the other Feature Gates.
Happy to close this PR and do PR to remove 'Custom' prefix if preferred.

Discovered this mismatch when attempting to set the Feature Gate with kubespray deploying a 1.14.1 cluster.

@karlskewes
CPUCFSQuotaPeriod - CLI Reference mismatch
5be2bca 
`CPUCFSQuotaPeriod` Feature Gate is set from the flag name `CustomCPUCFSQuotaPeriod` per [`kube_features.go#163`](https://github.com/kubernetes/kubernetes/blob/master/pkg/features/kube_features.go#L163)
This PR updates the docs to suit.

In some respects it would be tidier to remove `Custom` prefix from `kube_features.go` so that the Feature Gate naming maps 1:1.
Happy to close this PR and do PR to remove 'Custom' prefix instead.
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 28, 2019
@netlify
Copy link

netlify bot commented Apr 28, 2019

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 5be2bca

https://deploy-preview-14090--kubernetes-io-master-staging.netlify.com

@bradtopol
Copy link
Contributor

@szuecs Can you review this? It looks correct but the feature structure for this in
https://github.com/kubernetes/kubernetes/blob/master/pkg/features/kube_features.go#L163 seems different than all the other entries in the file so I wanted to make sure. Just as a /lgtm if you feel this PR is technically correct. Thanks!

@bradtopol
Copy link
Contributor

/assign

@szuecs
Copy link
Member

szuecs commented Apr 30, 2019 •
edited
Loading

/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 30, 2019
@szuecs
Copy link
Member

szuecs commented Apr 30, 2019

Thanks @kskewes

@bradtopol
Copy link
Contributor

Thanks @szuecs for the technical review. Great job @kskewes!!!
/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bradtopol, szuecs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 30, 2019
@k8s-ci-robot k8s-ci-robot merged commit 7533d70 into kubernetes:master Apr 30, 2019
@karlskewes karlskewes deleted the cfsquota branch April 30, 2019 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jimangel jimangel Awaiting requested review from jimangel

@xiangpengzhao xiangpengzhao Awaiting requested review from xiangpengzhao

Assignees

@szuecs szuecs

@bradtopol bradtopol

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@karlskewes @bradtopol @szuecs @k8s-ci-robot