Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed typo issue in /tutorials/stateful-application/zookeeper.md #13983

Merged
merged 1 commit into from
Apr 28, 2019
Merged

Fixed typo issue in /tutorials/stateful-application/zookeeper.md #13983

merged 1 commit into from
Apr 28, 2019

Conversation

avidLearnerInProgress
Copy link

Applied the minor fix associated with the issue: #13975

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. language/ko Issues or PRs related to Korean language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Apr 23, 2019
@avidLearnerInProgress
Copy link
Author

/language ko

@netlify
Copy link

netlify bot commented Apr 23, 2019

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 872022f

https://deploy-preview-13983--kubernetes-io-master-staging.netlify.com

@claudiajkang claudiajkang changed the base branch from master to dev-1.14-ko.3 April 26, 2019 09:49
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 26, 2019
@claudiajkang
Copy link
Contributor

claudiajkang commented Apr 26, 2019 •
edited
Loading

/assign

@avidLearnerInProgress Thank you for your contribution.

Your PR does not have any problem.

But, the working branch of Korean Localization team is dev-1.14-ko.3.
So, could you change the base branch master to dev-1.14-ko.3 in this PR?

@avidLearnerInProgress
Copy link
Author

avidLearnerInProgress commented Apr 26, 2019 •
edited by claudiajkang
Loading

/assign

@avidLearnerInProgress Thank you for your contribution.

Your PR does not have any problem.

But, the working branch of Korean Localization team is dev-1.14-ko.3.
So, could you change the base branch master to dev-1.14-ko.3 in this PR?

I can see the base branch being displayed as: dev-1.14-ko.3:

image

Is this okay or do I need to change something?

@avidLearnerInProgress @claudiajkang
Fixed the ko-typo
c3411fd 
Associated to the issue: kubernetes#13975
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Apr 28, 2019
@claudiajkang
Copy link
Contributor

@avidLearnerInProgress

Thank you!

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 28, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ClaudiaJKang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 28, 2019
@netlify
Copy link

netlify bot commented Apr 28, 2019

Deploy preview for k8s-dev-ko ready!

Built with commit c3411fd

https://deploy-preview-13983--k8s-dev-ko.netlify.com

@k8s-ci-robot k8s-ci-robot merged commit 156a139 into kubernetes:dev-1.14-ko.3 Apr 28, 2019
@claudiajkang claudiajkang mentioned this pull request May 6, 2019
Merged
claudiajkang pushed a commit that referenced this pull request May 7, 2019
@gochist @uncle-elephant
@seokho-son @claudiajkang
This PR is the third Korean l10n work for release-1.14.
e313f4f 
* Fixed the ko-typo (#13983)

* ko: Update outdated files in dev-1.14-ko.3 (#14055)

* Translate concepts/overview/working-with-objects/annotations in Korean (#14115)

Co-authored-by:    Chirag Shah <[email protected]>
Co-authored-by:    June Yi <[email protected]>
Co-authored-by:	Claudia J. Kang <[email protected]>
Co-authored-by:    uncle-elephant <[email protected]>
Co-authored-by:    Seokho <[email protected]>
k8s-ci-robot pushed a commit that referenced this pull request May 7, 2019
@claudiajkang @gochist
@uncle-elephant @seokho-son @k8s-ci-robot
This PR is the third Korean l10n work for release-1.14. (#14185)
1054269 
* Fixed the ko-typo (#13983)

* ko: Update outdated files in dev-1.14-ko.3 (#14055)

* Translate concepts/overview/working-with-objects/annotations in Korean (#14115)

Co-authored-by:    Chirag Shah <[email protected]>
Co-authored-by:    June Yi <[email protected]>
Co-authored-by:	Claudia J. Kang <[email protected]>
Co-authored-by:    uncle-elephant <[email protected]>
Co-authored-by:    Seokho <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@claudiajkang claudiajkang Awaiting requested review from claudiajkang

@ianychoi ianychoi Awaiting requested review from ianychoi

Assignees

@claudiajkang claudiajkang

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/ko Issues or PRs related to Korean language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@avidLearnerInProgress @claudiajkang @k8s-ci-robot