-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Localised /partners/_index.html #13916
Conversation
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Deploy preview for kubernetes-io-master-staging ready! Built with commit 88ff997 https://deploy-preview-13916--kubernetes-io-master-staging.netlify.com |
@saarques It seems like you have committed all the English files too. |
/hold |
Hello @saarques, as @mittalyashu this PR contains a lot more than the localized file. Please remove all the files but If you have any doubt, don't hesitate to ask on slack. |
Hey @mittalyashu , @raelga I have removed extra un-necessary files. |
content/hi/partners/_index.html
Outdated
|
||
<section id="users"> | ||
<main> | ||
<h5>कुबरनेट्स सहयोगियों संग एक मज़बूत, जीवंत कोड बेस का निर्माण करता है जो संपूरक मंचों के स्पेक्ट्रम को सहयोग करता है।</h5> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are few words which are not making up the sentence.
Like जीवंत
and संपूरक
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think both these words perfectly satisfy the words for this particular context.
Also, we can remove जीवंत from the sentence as the meaning will almost be the same either way.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, you are right we can remove जीवंत
, it doesn't change the meaning of the sentence.
The correct spellings of संपूरक
are संपूर्ण
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay I will remove जीवंत from the translation, also संपूरक means Complementary while संपूर्ण means Complete, these are both totally different words, so I will keep this as it is.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's just to make the sentence easier, it better to use संपूर्ण
, otherwise using संपूरक
is also not a bad choice
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks.
content/hi/partners/_index.html
Outdated
<b>प्रमाणित कूबरनेट्स Distributions, Hosted Platforms, तथा Installers</b> | ||
</h5>सॉफ्टवेयर अनुरूप चलने से ये सुनिश्चित किया जाता है कि प्रत्येक विक्रेता का संस्करण जरूरी API का समर्थन करे। | ||
<br><br><br> | ||
<button id="conformance" class="button" onClick="updateSrc(this.id)">अनुरूप सहयोगी देखें</button> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This sentence is not matching up अनुरूप सहयोगी देखें
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please translate it for me!
"See Conformance partners"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Translation of See Conformance partners
is अनुरूपता भागीदार देखें
How about सहभागी
?
अनुरूप सहभागी देखें
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
सहयोगी, भागीदार and सहभागी can all be used in place of partners, I thought the problem is with the whole sentence, So, I am concluding that there is no problem with the translation meaning.
Either way, I will take your suggestion and overwrite the original one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks.
Rest of the translation looks good to me, but there are two sentences which don't look good. |
Thanks @saarques! Removing /hold cancel Aside from the review, to be able to merge your content in to master you need to sign the CLA. Please check https://git.k8s.io/community/CLA.md#the-contributor-license-agreement for more information. |
I have signed the CLA. |
/language hi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just made some general comments. @avidLearnerInProgress and @mittalyashu please take a look.
content/hi/partners/_index.html
Outdated
<b>प्रमाणित कूबरनेट्स Distributions, Hosted Platforms, तथा Installers</b> | ||
</h5>सॉफ्टवेयर अनुरूप चलने से ये सुनिश्चित किया जाता है कि प्रत्येक विक्रेता का संस्करण जरूरी API का समर्थन करे। | ||
<br><br><br> | ||
<button id="conformance" class="button" onClick="updateSrc(this.id)">अनुरूप सहभागी देखें</button> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
may be: अनुपालन सहभागियों को देखें
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't अनुपालन a very different word in this context?
content/hi/partners/_index.html
Outdated
<center> | ||
<h5> | ||
<b>प्रमाणित कूबरनेट्स Distributions, Hosted Platforms, तथा Installers</b> | ||
</h5>सॉफ्टवेयर अनुरूप चलने से ये सुनिश्चित किया जाता है कि प्रत्येक विक्रेता का संस्करण जरूरी API का समर्थन करे। |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
may be: सॉफ्टवेयर अनुपालनसे ये सुनिश्चित किया जाता है कि प्रत्येक विक्रेता का version जरूरी API का समर्थन करे।
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add spacing between अनुपालन
and से
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should I do it सॉफ्टवेयर के अनुपालन से ये सुनिश्चित .....?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah.
content/hi/partners/_index.html
Outdated
</h5> | ||
<br>उद्यमों द्वारा कुबरनेट्स सफलतापूर्वक अपनाने में सहभागी अनुभवी सेवा प्रदाता। | ||
<br><br><br> | ||
<button id="kcsp" class="button" onClick="updateSrc(this.id)">KCSP सहभागी देखें</button> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
may be: सहभागियों को देखें
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can be done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These can be done.
content/hi/partners/_index.html
Outdated
</div> | ||
<div class="col-nav"> | ||
<center> | ||
<h5><b>कूबरनेट्स प्रशिक्षण सहभागी</b></h5> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
may be: कुबेरनेट्स प्रशिक्षण सहभागियों
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think so, will wait for others to review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This sentence कुबेरनेट्स प्रशिक्षण सहभागियों
is not matching up @Rajakavitha1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
सहभागी
or सहभागियों
is not really helping here, how about कूबरनेट्स प्रशिक्षण प्रदाता
means Kubernetes training provider.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is actually "Kubernetes Training Partners" in the English version, I think प्रदाता (Provider) will change the whole meaning.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know it will change the sentence but the meaning should be the same, these are the trainers who provide Kubernetes training.
content/hi/partners/_index.html
Outdated
<h5><b>कूबरनेट्स प्रशिक्षण सहभागी</b></h5> | ||
<br>Cloud native तकनीक के अनुभवी प्रशिक्षक। | ||
<br><br><br><br> | ||
<button id="ktp" class="button" onClick="updateSrc(this.id)"> KTP सहभागी देखें</button> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
may be: सहभागियों को देखें
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure.
New changes are detected. LGTM label has been removed. |
@saarques Is this PR ready to get merged? |
I actually tried squashing the commits and created some mess, afterwords I
tried sorting it and I think I need a LGTM on this pr first and then squash
again.
…On Wed 23 Oct, 2019, 11:35 AM Yashu Mittal, ***@***.***> wrote:
@saarques <https://github.com/saarques> Is this PR ready to get merged?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#13916?email_source=notifications&email_token=AHER2AR7RXJHSW6N4UCHJTLQP7SUPA5CNFSM4HHJVBTKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOECAFWAQ#issuecomment-545282818>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AHER2AXRXOLPBXNHHCIKG2LQP7SUPANCNFSM4HHJVBTA>
.
|
@saarques Were you able to fix all the merge conflicts? |
@saarques 👋 Please feel free to /close |
@zacharysarah: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Translated one file from /content/en/partners to Hindi.
Closes #13911