Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update content on kube-dns to coredns configmap translation #13781

Closed
wants to merge 4 commits into from
Closed

Update content on kube-dns to coredns configmap translation #13781

wants to merge 4 commits into from

Conversation

rajansandeep
Copy link
Contributor

Updates and corrects the part of configmap for CoreDNS

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 11, 2019
@rajansandeep
Copy link
Contributor Author

/cc @chrisohaver

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 11, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: steveperry-53

If they are not already assigned, you can assign the PR to them by writing /assign @steveperry-53 in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Apr 11, 2019
@netlify
Copy link

netlify bot commented Apr 11, 2019 •
edited
Loading

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 556b77d

https://deploy-preview-13781--kubernetes-io-master-staging.netlify.com

@chrisohaver @rajansandeep
better wording
351414d 
Co-Authored-By: rajansandeep <[email protected]>
@chrisohaver
Copy link
Contributor

Is this for k8s 1.14, or 1.15?

chrisohaver
chrisohaver reviewed Apr 11, 2019
View reviewed changes
Copy link
Contributor

@chrisohaver chrisohaver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see single comments

@rajansandeep
Copy link
Contributor Author

Is this for k8s 1.14, or 1.15?

This PR is aimed for 1.15, as the PR which fixes the translation is also for 1.15 release.

@rajansandeep rajansandeep changed the base branch from master to dev-1.15 April 11, 2019 15:53
@rajansandeep rajansandeep changed the base branch from dev-1.15 to master April 11, 2019 15:53
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Apr 11, 2019
@rajansandeep
Copy link
Contributor Author

test coredns

@tengqm
Copy link
Contributor

tengqm commented Apr 15, 2019

@rajansandeep Please rebase this onto dev-1.15 branch. Master is for 1.14 only.
/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 15, 2019
@rajansandeep
Copy link
Contributor Author

Closing this in favor of #13826
/close

@k8s-ci-robot
Copy link
Contributor

@rajansandeep: Closed this PR.

In response to this:

Closing this in favor of #13826
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisohaver chrisohaver chrisohaver approved these changes

@bowei bowei Awaiting requested review from bowei

@xiangpengzhao xiangpengzhao Awaiting requested review from xiangpengzhao

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rajansandeep @k8s-ci-robot @chrisohaver @tengqm