Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reversal of CSI ephemeral inline volume doc #13403

Merged
merged 1 commit into from
Mar 28, 2019
Merged

Reversal of CSI ephemeral inline volume doc #13403

merged 1 commit into from
Mar 28, 2019

Conversation

vladimirvivien
Copy link
Member

This is a reversal of PR #10934. That alpha feature has a non-critical bug that will not be fixed until 1.15.

@k8sio-netlify-preview-bot
Copy link
Collaborator

k8sio-netlify-preview-bot commented Mar 25, 2019 •
edited
Loading

Deploy preview for kubernetes-io-vnext-staging processing.

Building with commit 2875d53

https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/5c9be134025dd80008c5bab2

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 25, 2019
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Mar 25, 2019
@vladimirvivien
Copy link
Member Author

PTAL
/assign @jimangel

@jimangel
Copy link
Member

/retest

@jimangel
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 26, 2019
@vladimirvivien
Copy link
Member Author

/retest

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 27, 2019
@jimangel jimangel changed the base branch from dev-1.14 to master March 28, 2019 22:13
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 28, 2019
@jimangel jimangel changed the base branch from master to dev-1.14 March 28, 2019 22:13
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Mar 28, 2019
@jimangel
Copy link
Member

@vladimirvivien sorry for all the back and forth on this. Can you rebase this against master? I just tried manually doing it through the GUI, but it pulled in a lot of extra stuff.

@vladimirvivien vladimirvivien changed the base branch from dev-1.14 to master March 28, 2019 22:21
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 28, 2019
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Mar 28, 2019
@vladimirvivien
Copy link
Member Author

@jimangel rebased against master

@netlify
Copy link

netlify bot commented Mar 28, 2019

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 3dafabc

https://deploy-preview-13403--kubernetes-io-master-staging.netlify.com

@netlify
Copy link

netlify bot commented Mar 28, 2019

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 3dafabc

https://deploy-preview-13403--kubernetes-io-master-staging.netlify.com

@jimangel
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 28, 2019
@k8s-ci-robot k8s-ci-robot merged commit e3ee3f8 into kubernetes:master Mar 28, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jimangel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saad-ali saad-ali Awaiting requested review from saad-ali

@zhangxiaoyu-zidif zhangxiaoyu-zidif Awaiting requested review from zhangxiaoyu-zidif

Assignees

@jimangel jimangel

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vladimirvivien @k8sio-netlify-preview-bot @jimangel @k8s-ci-robot