Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update configure-service-account task file to reference pod spec file… #13065

Merged
merged 1 commit into from
Mar 12, 2019
Merged

Update configure-service-account task file to reference pod spec file… #13065

merged 1 commit into from
Mar 12, 2019

Conversation

DanyC97
Copy link
Contributor

@DanyC97 DanyC97 commented Mar 11, 2019

… from examples dir

This PR is part of the initiative started #12740

It does address few things:

  • aligns with the style guidelines
  • add the pod spec file to example directory and referencing it using codenew shortcode
  • remove extra/ not needed space (cosmetic, no UX benefit)

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language labels Mar 11, 2019
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 11, 2019
@netlify
Copy link

netlify bot commented Mar 11, 2019 •
edited
Loading

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 0a71284

https://deploy-preview-13065--kubernetes-io-master-staging.netlify.com

@zacharysarah
Copy link
Contributor

@DanyC97 👋 This also needs a new test case in examples/examples_test.go for pods/pod-projected-svc-token.yaml.

@DanyC97
Copy link
Contributor Author

DanyC97 commented Mar 11, 2019

on it, thanks !

@DanyC97 DanyC97 force-pushed the tasks-cpc-csvc-acc branch 2 times, most recently from 32fc3ef to 4580247 Compare March 12, 2019 10:27
@DanyC97
Copy link
Contributor Author

DanyC97 commented Mar 12, 2019

yes !! it just caught a wrong pod spec 🎉

examples_test.go:609: pods/pod-projected-svc-token.yaml did not validate correctly: [metadata.name: Required value: name or generateName is required spec.volumes[0].projected.serviceAccountToken: Forbidden: TokenRequestProjection feature is not enabled spec.containers[0].volumeMounts[0].name: Not found: "vault-token"]

@DanyC97 DanyC97 force-pushed the tasks-cpc-csvc-acc branch from 4580247 to 343191f Compare March 12, 2019 11:50
@DanyC97 DanyC97 force-pushed the tasks-cpc-csvc-acc branch from 343191f to 0a71284 Compare March 12, 2019 12:00
@DanyC97
Copy link
Contributor Author

DanyC97 commented Mar 12, 2019

@zacharysarah Travis is a happy 🐰

@DanyC97
Copy link
Contributor Author

DanyC97 commented Mar 12, 2019

@tengqm please help review

@zacharysarah
Copy link
Contributor

Looks good in the preview:
Screen Shot 2019-03-12 at 12 35 01 PM

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 12, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zacharysarah

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 12, 2019
@k8s-ci-robot k8s-ci-robot merged commit da20b13 into kubernetes:master Mar 12, 2019
@DanyC97 DanyC97 deleted the tasks-cpc-csvc-acc branch March 12, 2019 20:46
yagonobre pushed a commit to yagonobre/website that referenced this pull request Mar 14, 2019
@DanyC97 @yagonobre
Update configure-service-account task file to reference pod spec file…
e97e86e 
… from examples dir (kubernetes#13065)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bprashanth bprashanth Awaiting requested review from bprashanth

@Rajakavitha1 Rajakavitha1 Awaiting requested review from Rajakavitha1

Assignees

@zacharysarah zacharysarah

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DanyC97 @zacharysarah @k8s-ci-robot