Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

i18n/ko.toml added kubeweekly's contents #12875

Merged
merged 1 commit into from
Mar 11, 2019
Merged

i18n/ko.toml added kubeweekly's contents #12875

merged 1 commit into from
Mar 11, 2019

Conversation

claudiajkang
Copy link
Contributor

#12873's updated contents added i18n/ko.toml.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 27, 2019
@claudiajkang
Copy link
Contributor Author

/cc @gochist

@k8s-ci-robot k8s-ci-robot requested a review from gochist February 27, 2019 10:19
@netlify
Copy link

netlify bot commented Feb 27, 2019

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 4602595

https://deploy-preview-12875--kubernetes-io-master-staging.netlify.com

@claudiajkang claudiajkang changed the title i18n/ko.toml added #12873's contents i18n/ko.toml added kubeweekly's contents Feb 27, 2019
@gochist
Copy link
Member

gochist commented Mar 1, 2019

As a native Korean speaker, LGTM.

@claudiajkang
Copy link
Contributor Author

/assign @cody-clark

@claudiajkang
Copy link
Contributor Author

@cody-clark ping?

@cody-clark
Copy link
Contributor

Hi @claudiajkang, sorry for the delay. I'm not a ko-owner, but I didn't hear back in the Slack. I'll go ahead and try to to approve this to not be a blocker.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 11, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cody-clark

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 11, 2019
@k8s-ci-robot k8s-ci-robot merged commit 60f89ad into kubernetes:master Mar 11, 2019
@zacharysarah
Copy link
Contributor

@cody-clark Good call. 👍

@claudiajkang
Copy link
Contributor Author

@cody-clark Thank you!

yagonobre pushed a commit to yagonobre/website that referenced this pull request Mar 14, 2019
@claudiajkang @yagonobre
i18n/ko.toml added kubernetes#12873's contents (kubernetes#12875)
d30e0fa
@gochist gochist mentioned this pull request Apr 24, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rajakavitha1 Rajakavitha1 Awaiting requested review from Rajakavitha1

@stewart-yu stewart-yu Awaiting requested review from stewart-yu

@gochist gochist Awaiting requested review from gochist

Assignees

@cody-clark cody-clark

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@claudiajkang @gochist @cody-clark @k8s-ci-robot @zacharysarah