Fix #12810 - Missing docs for ingress setup on minikube #12821
Conversation
k8s-ci-robot
added
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: If they are not already assigned, you can assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
size/M
|
Deploy preview for kubernetes-io-master-staging ready! Built with commit a941179 https://deploy-preview-12821--kubernetes-io-master-staging.netlify.com |
|
/assign @steveperry-53 |
| @@ -160,19 +159,19 @@ The following file is an Ingress resource that sends traffic to your Service via | |||
| ``` | |||
|
|
|||
| 1. Create the Ingress resrouce by running the following command: | |||
|
|
|||
There was a problem hiding this comment.
Good updates.
nit: correct the spelling of resource in line 161.
| @@ -195,9 +194,9 @@ The following file is an Ingress resource that sends traffic to your Service via | |||
|
|
|||
| 1. Verify that the Ingress contorller is directing traffic: | |||
|
|
|||
There was a problem hiding this comment.
nit: line 195, correct spelling of controller
nit: should this be item number 5? Probably an extra line needs to be taken away or added.
| @@ -252,7 +251,7 @@ The following file is an Ingress resource that sends traffic to your Service via | |||
| kubectl apply -f example-ingress.yaml | |||
| ``` | |||
|
|
|||
There was a problem hiding this comment.
nit: check item ordering (1, 2 vs 1, 1). May need to add/delete extra line.
|
@kbhawkey Thank you so much for the review! I will update the PR right away. |
k8s-ci-robot
added
size/L
|
@kbhawkey Addressed all the issues! |
|
@daminisatya Could I please have you fix the merge conflicts, otherwise I think this is ready to go! |
k8s-ci-robot
added
size/M
| @@ -45,7 +45,7 @@ uses a service of type [Service.Type=NodePort](/docs/concepts/services-networkin | |||
|
|
|||
| {{< feature-state for_k8s_version="v1.1" state="beta" >}} | |||
|
|
|||
| Before you start using an Ingress, there are a few things you should understand. The Ingress is a beta resource. | |||
| Before you start using an Ingress, there are a few things you should understand. The Ingress is a beta resource. | |||
There was a problem hiding this comment.
I'm assuming that Ingress has left beta; we're long past v1.1. Is that right?
There was a problem hiding this comment.
This needs to be confirmed before it's updated in the document. Also, I don't think it is related to the current. We can open another bug to track it.
#12810
Fix One - Removed .md from the URL
Fix Two - the YAML formatting is correctly shown. here are the screenshots before and after the changes.
Before -
After fix -