Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bugs about kubeadm upgrading. #12809

Merged
merged 4 commits into from
Feb 25, 2019
Merged

Fix bugs about kubeadm upgrading. #12809

merged 4 commits into from
Feb 25, 2019

Conversation

Mr-Linus
Copy link
Contributor

It will lead to the following error if using yum upgrade -y kubeadm --disableexcludes=kubernetes command:
https://serverfault.com/questions/943696/fatal-unexpected-error-when-reading-kubeadm-config-configmap-clusterconfigurat

Running yum upgrade -y kubeadm --disableexcludes=kubernetes command will upgrade the kubeadm to v1.13, but kubeadm v1.13 could not upgrade the v1.11 kubeadm cluster.

It will lead to the following error if using `yum upgrade -y kubeadm --disableexcludes=kubernetes` command:
<https://serverfault.com/questions/943696/fatal-unexpected-error-when-reading-kubeadm-config-configmap-clusterconfigurat>
Running `yum upgrade -y kubeadm --disableexcludes=kubernetes` command will upgrade the kubeadm to v1.13 but kubeadm v1.13 could not upgrade the v1.12 kubeadm cluster.
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. language/en Issues or PRs related to English language labels Feb 24, 2019
@netlify
Copy link

netlify bot commented Feb 24, 2019

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 7a424f3

https://deploy-preview-12809--kubernetes-io-master-staging.netlify.com

Copy link
Member

@neolit123 neolit123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the PR @Mr-Linus
added one minor comment.
/sig cluster-lifecycle

@@ -44,7 +44,7 @@ This page explains how to upgrade a Kubernetes cluster created with `kubeadm` fr
apt-mark hold kubeadm
{{% /tab %}}
{{% tab name="CentOS, RHEL or Fedora" %}}
yum upgrade -y kubeadm --disableexcludes=kubernetes
yum upgrade -y kubeadm-1.12.5 --disableexcludes=kubernetes
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

instead of pinning a PATCH version, this can be done:

# replace "x" with the latest patch version
yum upgrade -y kubeadm-1.12.x --disableexcludes=kubernetes

similar has to be done for this section:

Upgrade the Kubernetes package version on each $NODE node by running the Linux package manager for your distribution:

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finished! Thank you for your reminder!

@k8s-ci-robot k8s-ci-robot added sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. labels Feb 24, 2019
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 24, 2019
Copy link
Member

@neolit123 neolit123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 24, 2019
@zhangxiaoyu-zidif
Copy link
Contributor

ping @xiangpeng
for kubeadm reviewing

@Rajakavitha1
Copy link
Contributor

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Rajakavitha1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 25, 2019
@k8s-ci-robot k8s-ci-robot merged commit 924d764 into kubernetes:master Feb 25, 2019
kwiesmueller pushed a commit to kwiesmueller/website that referenced this pull request Feb 28, 2019
* Fix bug about kubeadm upgrading

It will lead to the following error if using `yum upgrade -y kubeadm --disableexcludes=kubernetes` command:
<https://serverfault.com/questions/943696/fatal-unexpected-error-when-reading-kubeadm-config-configmap-clusterconfigurat>
Running `yum upgrade -y kubeadm --disableexcludes=kubernetes` command will upgrade the kubeadm to v1.13 but kubeadm v1.13 could not upgrade the v1.12 kubeadm cluster.

* Update kubeadm-upgrade-1-12.md

* Update kubeadm-upgrade-1-12.md

* Update kubeadm-upgrade-1-12.md
krmayankk pushed a commit to krmayankk/kubernetes.github.io that referenced this pull request Mar 11, 2019
* Fix bug about kubeadm upgrading

It will lead to the following error if using `yum upgrade -y kubeadm --disableexcludes=kubernetes` command:
<https://serverfault.com/questions/943696/fatal-unexpected-error-when-reading-kubeadm-config-configmap-clusterconfigurat>
Running `yum upgrade -y kubeadm --disableexcludes=kubernetes` command will upgrade the kubeadm to v1.13 but kubeadm v1.13 could not upgrade the v1.12 kubeadm cluster.

* Update kubeadm-upgrade-1-12.md

* Update kubeadm-upgrade-1-12.md

* Update kubeadm-upgrade-1-12.md
yagonobre pushed a commit to yagonobre/website that referenced this pull request Mar 14, 2019
* Fix bug about kubeadm upgrading

It will lead to the following error if using `yum upgrade -y kubeadm --disableexcludes=kubernetes` command:
<https://serverfault.com/questions/943696/fatal-unexpected-error-when-reading-kubeadm-config-configmap-clusterconfigurat>
Running `yum upgrade -y kubeadm --disableexcludes=kubernetes` command will upgrade the kubeadm to v1.13 but kubeadm v1.13 could not upgrade the v1.12 kubeadm cluster.

* Update kubeadm-upgrade-1-12.md

* Update kubeadm-upgrade-1-12.md

* Update kubeadm-upgrade-1-12.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants