Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update debug-pod-replication-controller task file and and fix the kubectl grep #12797

Merged

Conversation

DanyC97
Copy link
Contributor

@DanyC97 DanyC97 commented Feb 22, 2019

This PR is one of the #12740 's tasks

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 22, 2019
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. language/en Issues or PRs related to English language labels Feb 22, 2019
@DanyC97
Copy link
Contributor Author

DanyC97 commented Feb 22, 2019

/assign @Rajakavitha1

@netlify
Copy link

netlify bot commented Feb 22, 2019

Deploy preview for kubernetes-io-master-staging ready!

Built with commit ec253bf

https://deploy-preview-12797--kubernetes-io-master-staging.netlify.com

@DanyC97
Copy link
Contributor Author

DanyC97 commented Feb 25, 2019

any help here with reviewing please ?

@DanyC97 DanyC97 force-pushed the tasks-debug-app-cluster-dprc branch from b713552 to ec253bf Compare February 26, 2019 11:18
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 26, 2019
@DanyC97 DanyC97 changed the title Update the debug-pod-replication-controller task file and fix the nod… Update debug-pod-replication-controller task file and and fix the kubectl grep Feb 26, 2019
@DanyC97
Copy link
Contributor Author

DanyC97 commented Feb 28, 2019

/assign @zparnold

@DanyC97
Copy link
Contributor Author

DanyC97 commented Feb 28, 2019

/unassign @Rajakavitha1

@DanyC97
Copy link
Contributor Author

DanyC97 commented Mar 4, 2019

who can help out here with review/ approve ?

@DanyC97
Copy link
Contributor Author

DanyC97 commented Mar 7, 2019

/sig docs

@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Mar 7, 2019
@zacharysarah
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 7, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zacharysarah

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 7, 2019
@k8s-ci-robot k8s-ci-robot merged commit 4bd4690 into kubernetes:master Mar 7, 2019
@DanyC97 DanyC97 deleted the tasks-debug-app-cluster-dprc branch March 7, 2019 22:31
krmayankk pushed a commit to krmayankk/kubernetes.github.io that referenced this pull request Mar 11, 2019
yagonobre pushed a commit to yagonobre/website that referenced this pull request Mar 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants