Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow the style guide #12760

Closed

Conversation

makocchi-git
Copy link
Contributor

No description provided.

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. language/en Issues or PRs related to English language labels Feb 21, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: bradtopol

If they are not already assigned, you can assign the PR to them by writing /assign @bradtopol in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 21, 2019
@netlify
Copy link

netlify bot commented Feb 21, 2019

Deploy preview for kubernetes-io-master-staging ready!

Built with commit d87917d

https://deploy-preview-12760--kubernetes-io-master-staging.netlify.com

@makocchi-git
Copy link
Contributor Author

preview is here
original

@DanyC97
Copy link
Contributor

DanyC97 commented Feb 22, 2019

nice, right on time with my PR #12783

@Rajakavitha1
Copy link
Contributor

Thanks for the PR @makocchi-git . There is a PR that addresses the consistency in code formatting. #12783. I am closing this PR for now.
Please feel free to open the PR after the recommended guidelines in #12783. are approved.

@Rajakavitha1
Copy link
Contributor

/close

@k8s-ci-robot
Copy link
Contributor

@Rajakavitha1: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@makocchi-git makocchi-git deleted the fix/init_container branch June 18, 2020 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants