Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use card based layout #12752

Merged
merged 1 commit into from
Feb 22, 2019
Merged

Use card based layout #12752

merged 1 commit into from
Feb 22, 2019

Conversation

iamneha
Copy link
Contributor

@iamneha iamneha commented Feb 21, 2019

Fixes issue: #12696

@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 21, 2019
@netlify
Copy link

netlify bot commented Feb 21, 2019 •
edited
Loading

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 4fedba5

https://deploy-preview-12752--kubernetes-io-master-staging.netlify.com

Rajakavitha1
Rajakavitha1 suggested changes Feb 21, 2019
View reviewed changes
Copy link
Contributor

@Rajakavitha1 Rajakavitha1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @iamneha !!!!

Could you please change name: concepts to name: contribute to keep it consistent with the name used in https://github.com/kubernetes/website/pull/12570/files

@Rajakavitha1 Rajakavitha1 mentioned this pull request Feb 21, 2019
Merged
@Rajakavitha1
Copy link
Contributor

/lgtm

/assign @zacharysarah

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 21, 2019
@Rajakavitha1
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Rajakavitha1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 22, 2019
@k8s-ci-robot k8s-ci-robot merged commit eaf7f1c into kubernetes:master Feb 22, 2019
kwiesmueller pushed a commit to kwiesmueller/website that referenced this pull request Feb 28, 2019
@iamneha
Use card based layout (kubernetes#12752)
79a7036
@iamneha iamneha mentioned this pull request Mar 8, 2019
Closed
6 tasks
krmayankk pushed a commit to krmayankk/kubernetes.github.io that referenced this pull request Mar 11, 2019
@iamneha
Use card based layout (kubernetes#12752)
86c3736
yagonobre pushed a commit to yagonobre/website that referenced this pull request Mar 14, 2019
@iamneha @yagonobre
Use card based layout (kubernetes#12752)
80304b1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rajakavitha1 Rajakavitha1 Rajakavitha1 requested changes

@xiangpengzhao xiangpengzhao Awaiting requested review from xiangpengzhao

@zhangxiaoyu-zidif zhangxiaoyu-zidif Awaiting requested review from zhangxiaoyu-zidif

Assignees

@zacharysarah zacharysarah

@Rajakavitha1 Rajakavitha1

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@iamneha @Rajakavitha1 @k8s-ci-robot @zacharysarah