Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the codenew shortcode where site.Params.githubWebRow is null #12743

Merged
merged 1 commit into from
Feb 21, 2019
Merged

Fix the codenew shortcode where site.Params.githubWebRow is null #12743

merged 1 commit into from
Feb 21, 2019

Conversation

DanyC97
Copy link
Contributor

@DanyC97 DanyC97 commented Feb 20, 2019

Fixes #12639

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 20, 2019
@DanyC97
Copy link
Contributor Author

DanyC97 commented Feb 20, 2019

@tengqm fyi

@netlify
Copy link

netlify bot commented Feb 20, 2019 •
edited
Loading

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 08b54de

https://deploy-preview-12743--kubernetes-io-master-staging.netlify.com

@DanyC97
Copy link
Contributor Author

DanyC97 commented Feb 20, 2019

/assign @ryanmcginnis

@ryanmcginnis
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 21, 2019
@tengqm
Copy link
Contributor

tengqm commented Feb 21, 2019

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ryanmcginnis, tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [ryanmcginnis,tengqm]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 9054d61 into kubernetes:master Feb 21, 2019
@DanyC97 DanyC97 deleted the fix-12639 branch February 21, 2019 01:05
@DanyC97
Copy link
Contributor Author

DanyC97 commented Feb 21, 2019

@tengqm does this need to be cherry picked into 1.13 branch too?
Or that is not required ? (still getting my head around, so excuse my silly question)

@tengqm
Copy link
Contributor

tengqm commented Feb 21, 2019

@DanyC97 Cherrypick to 1.13 should be desirable since it is a bug fix.

kwiesmueller pushed a commit to kwiesmueller/website that referenced this pull request Feb 28, 2019
@DanyC97
Fix the codenew shortcode where site.Params.githubWebRow is null (kub…
93ed00d 
…ernetes#12743)
krmayankk pushed a commit to krmayankk/kubernetes.github.io that referenced this pull request Mar 11, 2019
@DanyC97
Fix the codenew shortcode where site.Params.githubWebRow is null (kub…
60277e6 
…ernetes#12743)
yagonobre pushed a commit to yagonobre/website that referenced this pull request Mar 14, 2019
@DanyC97 @yagonobre
Fix the codenew shortcode where site.Params.githubWebRow is null (kub…
97581db 
…ernetes#12743)
This was referenced Aug 27, 2019
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rajakavitha1 Rajakavitha1 Awaiting requested review from Rajakavitha1

@xiangpengzhao xiangpengzhao Awaiting requested review from xiangpengzhao

Assignees

@tengqm tengqm

@ryanmcginnis ryanmcginnis

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@DanyC97 @ryanmcginnis @tengqm @k8s-ci-robot