-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add baidu cloud provider information #12738
Conversation
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Deploy preview for kubernetes-io-master-staging ready! Built with commit 36b2356 https://deploy-preview-12738--kubernetes-io-master-staging.netlify.com |
I've signed the CLA. |
/assign @kbarnard10 |
@m3ngyang Maybe you're using a different email address when signing the CLA. -_- |
/check-cla |
Checked the updates on: https://deploy-preview-12738--kubernetes-io-master-staging.netlify.com/docs/concepts/cluster-administration/cloud-providers/ nit: Should there be a space between Baidu and Cloud in the tab that reads BaiduCloud? |
@Rajakavitha1 thanks for your review, "Baidu Cloud" is better. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Rajakavitha1 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Add details about cloud provider node name computation and internal LoadBalancer annotation of Baidu cloud.