Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarified step of getting Kubernetes cluster name; fixed quoting in c… #12718

Merged
merged 2 commits into from
Mar 7, 2019
Merged

Clarified step of getting Kubernetes cluster name; fixed quoting in c… #12718

merged 2 commits into from
Mar 7, 2019

Conversation

aqnaqn
Copy link
Contributor

@aqnaqn aqnaqn commented Feb 19, 2019

…ommand that sets APISERVER.

Need to set CLUSTER_NAME before using it.
The single quote in the APISERVER command prevented the expansion of the CLUSTER_NAME variable.

@aqnaqn
Clarified step of getting Kubernetes cluster name; fixed quoting in c…
67dc869 
…ommand that sets `APISERVER`.

Need to set `CLUSTER_NAME` before using it.
The single quote in the `APISERVER` command prevented the expansion of the `CLUSTER_NAME` variable.
@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
  • If you have done the above and are still having issues with the CLA being reported as unsigned, please email the CNCF helpdesk: [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. language/en Issues or PRs related to English language labels Feb 19, 2019
@netlify
Copy link

netlify bot commented Feb 19, 2019 •
edited
Loading

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 4d9b7aa

https://deploy-preview-12718--kubernetes-io-master-staging.netlify.com

@aqnaqn
Copy link
Contributor Author

aqnaqn commented Feb 20, 2019

I signed it.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Feb 20, 2019
@Rajakavitha1
Copy link
Contributor

/assign @zparnold

@Rajakavitha1
Copy link
Contributor

Rajakavitha1 commented Feb 21, 2019 •
edited
Loading

Hi @zparnold could you please take a look at the updates made in this PR.

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 7, 2019
@zacharysarah
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 7, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zacharysarah

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 7, 2019
@k8s-ci-robot k8s-ci-robot merged commit d110471 into kubernetes:master Mar 7, 2019
krmayankk pushed a commit to krmayankk/kubernetes.github.io that referenced this pull request Mar 11, 2019
@aqnaqn
Clarified step of getting Kubernetes cluster name; fixed quoting in c… (
c48f075 
kubernetes#12718)

* Clarified step of getting Kubernetes cluster name; fixed quoting in command that sets `APISERVER`.

Need to set `CLUSTER_NAME` before using it.
The single quote in the `APISERVER` command prevented the expansion of the `CLUSTER_NAME` variable.

* Remove whitespace
yagonobre pushed a commit to yagonobre/website that referenced this pull request Mar 14, 2019
@aqnaqn @yagonobre
Clarified step of getting Kubernetes cluster name; fixed quoting in c… (
aa708dc 
kubernetes#12718)

* Clarified step of getting Kubernetes cluster name; fixed quoting in command that sets `APISERVER`.

Need to set `CLUSTER_NAME` before using it.
The single quote in the `APISERVER` command prevented the expansion of the `CLUSTER_NAME` variable.

* Remove whitespace
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zacharysarah zacharysarah zacharysarah approved these changes

@jimangel jimangel Awaiting requested review from jimangel

@zhangxiaoyu-zidif zhangxiaoyu-zidif Awaiting requested review from zhangxiaoyu-zidif

Assignees

@zacharysarah zacharysarah

@zparnold zparnold

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@aqnaqn @k8s-ci-robot @Rajakavitha1 @zacharysarah @zparnold