Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tidy install guide for container runtimes #12704

Merged
merged 4 commits into from
Feb 25, 2019

Conversation

sftim
Copy link
Contributor

@sftim sftim commented Feb 19, 2019

Changes to https://kubernetes.io/docs/setup/cri/

  • Use a {{< feature-state >}} note to indicate feature status
  • Make it clear these instructions apply to Linux
  • De-emphasise the advice on cgroupfs (because the detailed instructions are already adapted)
  • Explain what cgroup is short for

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 19, 2019
@netlify
Copy link

netlify bot commented Feb 19, 2019

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 4103a52

https://deploy-preview-12704--kubernetes-io-master-staging.netlify.com

@Rajakavitha1
Copy link
Contributor

/assign @bradtopol

@Rajakavitha1
Copy link
Contributor

@bradtopol Please take a look at this PR.

@bart0sh
Copy link
Contributor

bart0sh commented Feb 19, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 19, 2019
@Rajakavitha1
Copy link
Contributor

@bradtopol could you please take a look at this PR.

@bradtopol
Copy link
Contributor

Great job!
/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bradtopol

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 25, 2019
@k8s-ci-robot k8s-ci-robot merged commit e176143 into kubernetes:master Feb 25, 2019
kwiesmueller pushed a commit to kwiesmueller/website that referenced this pull request Feb 28, 2019
* Use feature-state note for CRI

* Note applicability to Linux hosts

* Explain cgroup ("control group")

* De-emphasize cgroup details

The individual runtime install steps already take account of this
advice.
krmayankk pushed a commit to krmayankk/kubernetes.github.io that referenced this pull request Mar 11, 2019
* Use feature-state note for CRI

* Note applicability to Linux hosts

* Explain cgroup ("control group")

* De-emphasize cgroup details

The individual runtime install steps already take account of this
advice.
yagonobre pushed a commit to yagonobre/website that referenced this pull request Mar 14, 2019
* Use feature-state note for CRI

* Note applicability to Linux hosts

* Explain cgroup ("control group")

* De-emphasize cgroup details

The individual runtime install steps already take account of this
advice.
@sftim sftim deleted the cri_use_stable branch June 9, 2021 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants