Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix minishift wording, remove broken link #12679

Merged
merged 1 commit into from
Feb 19, 2019

Conversation

Bradamant3
Copy link
Contributor

Per conversation in #sig-docs-maintainers on Slack, fix a wording issue and remove a broken link.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 18, 2019
@Bradamant3 Bradamant3 requested review from zacharysarah and removed request for mikedanese and brendandburns February 18, 2019 03:13
@netlify
Copy link

netlify bot commented Feb 18, 2019

Deploy preview for kubernetes-io-master-staging ready!

Built with commit b21f89a

https://deploy-preview-12679--kubernetes-io-master-staging.netlify.com

@Rajakavitha1
Copy link
Contributor

Rajakavitha1 commented Feb 18, 2019

Thanks for the PR @Bradamant3!!!! This makes it so much more clear.
I checked the updates on: https://deploy-preview-12679--kubernetes-io-master-staging.netlify.com/docs/setup/pick-right-solution/
nit: Do we have to replace & with and?

@Rajakavitha1
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 19, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Rajakavitha1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 19, 2019
@k8s-ci-robot k8s-ci-robot merged commit c51c2bb into kubernetes:master Feb 19, 2019
kwiesmueller pushed a commit to kwiesmueller/website that referenced this pull request Feb 28, 2019
krmayankk pushed a commit to krmayankk/kubernetes.github.io that referenced this pull request Mar 11, 2019
yagonobre pushed a commit to yagonobre/website that referenced this pull request Mar 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants