Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sysctl to glossary #12607

Merged
merged 2 commits into from
Feb 17, 2019
Merged

Add sysctl to glossary #12607

merged 2 commits into from
Feb 17, 2019

Conversation

sftim
Copy link
Contributor

@sftim sftim commented Feb 12, 2019

Associated with #5993

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 12, 2019
@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Feb 12, 2019
@netlify
Copy link

netlify bot commented Feb 12, 2019

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 8e8efac

https://deploy-preview-12607--kubernetes-io-master-staging.netlify.com

@zparnold
Copy link
Member

@sftim Made a small suggestion since we have clusters that run non-Unix style kernels.

@sftim
Copy link
Contributor Author

sftim commented Feb 16, 2019

With tweaks made, is this OK to approve?

@zparnold
Copy link
Member

Yep, thanks @sftim
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 17, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zparnold

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 17, 2019
@k8s-ci-robot k8s-ci-robot merged commit e6d672f into kubernetes:master Feb 17, 2019
@sftim sftim deleted the glossary_sysctl branch February 18, 2019 14:16
kwiesmueller pushed a commit to kwiesmueller/website that referenced this pull request Feb 28, 2019
* Add sysctl to glossary

* Make it clear that sysctl is for Unix-like OSs
krmayankk pushed a commit to krmayankk/kubernetes.github.io that referenced this pull request Mar 11, 2019
* Add sysctl to glossary

* Make it clear that sysctl is for Unix-like OSs
yagonobre pushed a commit to yagonobre/website that referenced this pull request Mar 14, 2019
* Add sysctl to glossary

* Make it clear that sysctl is for Unix-like OSs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants