Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add some details about certs #12579

Merged
merged 1 commit into from
Feb 17, 2019
Merged

Add some details about certs #12579

merged 1 commit into from
Feb 17, 2019

Conversation

MalloZup
Copy link
Contributor

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 11, 2019
@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Feb 11, 2019
@netlify
Copy link

netlify bot commented Feb 11, 2019 •
edited
Loading

Deploy preview for kubernetes-io-master-staging ready!

Built with commit e8ef927

https://deploy-preview-12579--kubernetes-io-master-staging.netlify.com

@MalloZup MalloZup mentioned this pull request Feb 11, 2019
Closed
@Rajakavitha1
Copy link
Contributor

/assign @neolit123

zparnold
zparnold suggested changes Feb 13, 2019
View reviewed changes
Copy link
Member

@zparnold zparnold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MalloZup Thanks for the contribution! Could you please address my comments? Thanks!

neolit123
neolit123 reviewed Feb 13, 2019
View reviewed changes
Copy link
Member

@neolit123 neolit123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MalloZup thanks

content/en/docs/tasks/administer-cluster/kubeadm/kubeadm-certs.md Outdated Show resolved Hide resolved
content/en/docs/tasks/administer-cluster/kubeadm/kubeadm-certs.md Outdated Show resolved Hide resolved
@MalloZup
Copy link
Contributor Author

th x @neolit123 @zparnold i will adress your comments soon

@MalloZup MalloZup force-pushed the kubeadm-renew branch 2 times, most recently from 5d96944 to e8ef927 Compare February 14, 2019 16:32
@MalloZup
Copy link
Contributor Author

MalloZup commented Feb 14, 2019 •
edited
Loading

@neolit123 @zparnold please re-review once you have time. TIA 🚀

neolit123
neolit123 approved these changes Feb 14, 2019
View reviewed changes
Copy link
Member

@neolit123 neolit123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgm
/sig cluster-lifecycle
we need to add a lot more details in this doc eventually.

@k8s-ci-robot k8s-ci-robot added the sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. label Feb 14, 2019
@Rajakavitha1
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 16, 2019
@Rajakavitha1
Copy link
Contributor

/assign @Bradamant3
Could you please take a look at this PR.

@zparnold
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zparnold

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 17, 2019
@k8s-ci-robot k8s-ci-robot merged commit f156d51 into kubernetes:master Feb 17, 2019
kwiesmueller pushed a commit to kwiesmueller/website that referenced this pull request Feb 28, 2019
@MalloZup
Improve doc on certificates (kubernetes#12579)
465cc45
krmayankk pushed a commit to krmayankk/kubernetes.github.io that referenced this pull request Mar 11, 2019
@MalloZup
Improve doc on certificates (kubernetes#12579)
a577147
yagonobre pushed a commit to yagonobre/website that referenced this pull request Mar 14, 2019
@MalloZup @yagonobre
Improve doc on certificates (kubernetes#12579)
bf6a50f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zparnold zparnold zparnold requested changes

@neolit123 neolit123 neolit123 approved these changes

@Rajakavitha1 Rajakavitha1 Awaiting requested review from Rajakavitha1

@stewart-yu stewart-yu Awaiting requested review from stewart-yu

Assignees

@neolit123 neolit123

@Bradamant3 Bradamant3

@Rajakavitha1 Rajakavitha1

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@MalloZup @Rajakavitha1 @zparnold @k8s-ci-robot @neolit123 @Bradamant3