Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update building-from-source.md #12577

Merged
merged 2 commits into from
Feb 17, 2019
Merged

Update building-from-source.md #12577

merged 2 commits into from
Feb 17, 2019

Conversation

VineethReddy02
Copy link
Contributor

@VineethReddy02 VineethReddy02 commented Feb 11, 2019 •
edited
Loading

Update the page to be consistent with the concepts template.

@VineethReddy02
Update building-from-source.md
602900a 
Update the page to be consistent with the concepts template.
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 11, 2019
@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Feb 11, 2019
@netlify
Copy link

netlify bot commented Feb 11, 2019 •
edited
Loading

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 628af54

https://deploy-preview-12577--kubernetes-io-master-staging.netlify.com

@VineethReddy02
Copy link
Contributor Author

VineethReddy02 commented Feb 11, 2019 •
edited
Loading

screenshot 50

Updated the "Building from Source" template headers to be consistent.

@VineethReddy02
Update building-from-source.md
628af54 
Update the page to be consistent with the concepts template.
@VineethReddy02
Copy link
Contributor Author

/assign zhangxiaoyu-zidif
Please review the changes i made at: https://deploy-preview-12577--kubernetes-io-master-staging.netlify.com/docs/setup/release/building-from-source/ and let me know if any changes need to be made.

@zparnold
Copy link
Member

@VineethReddy02 Hey there! 👋 thanks for the contribution. On first glance, it's a little hard for me to tell what you are achieving here. Is it just to change the look/feel? It seems like some language is also changed here

@VineethReddy02
Copy link
Contributor Author

VineethReddy02 commented Feb 13, 2019 •
edited
Loading

Hi Zach!
In This PR Building from Source is repetitive, would like to update it to Building a release. Considering better understanding and eliminating redundancy in docs! :)
@zparnold

@zparnold
Copy link
Member

Yep! Makes more sense. Thanks!
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 17, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zparnold

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 17, 2019
@k8s-ci-robot k8s-ci-robot merged commit d521f97 into kubernetes:master Feb 17, 2019
kwiesmueller pushed a commit to kwiesmueller/website that referenced this pull request Feb 28, 2019
@VineethReddy02
Update building-from-source.md (kubernetes#12577)
d54d278 
* Update building-from-source.md

Update the page to be consistent with the concepts template.

* Update building-from-source.md

Update the page to be consistent with the concepts template.
krmayankk pushed a commit to krmayankk/kubernetes.github.io that referenced this pull request Mar 11, 2019
@VineethReddy02
Update building-from-source.md (kubernetes#12577)
1a9a71c 
* Update building-from-source.md

Update the page to be consistent with the concepts template.

* Update building-from-source.md

Update the page to be consistent with the concepts template.
yagonobre pushed a commit to yagonobre/website that referenced this pull request Mar 14, 2019
@VineethReddy02 @yagonobre
Update building-from-source.md (kubernetes#12577)
9e2c511 
* Update building-from-source.md

Update the page to be consistent with the concepts template.

* Update building-from-source.md

Update the page to be consistent with the concepts template.
@VineethReddy02 VineethReddy02 mentioned this pull request Jul 29, 2019
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@david-mcmahon david-mcmahon Awaiting requested review from david-mcmahon

@jbeda jbeda Awaiting requested review from jbeda

Assignees

@zhangxiaoyu-zidif zhangxiaoyu-zidif

@zparnold zparnold

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@VineethReddy02 @zparnold @k8s-ci-robot @zhangxiaoyu-zidif