Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update fluentd 0.12 to 1.0 in the example #12557

Merged
merged 2 commits into from
Feb 13, 2019
Merged

Update fluentd 0.12 to 1.0 in the example #12557

merged 2 commits into from
Feb 13, 2019

Conversation

oke-py
Copy link
Contributor

@oke-py oke-py commented Feb 8, 2019

Log Collector Examples was really helpful, but I suggest fluentd be updated to current stable version 1.0. I modified 2 documentation links, and syntax in the example.

syntax references:

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. language/en Issues or PRs related to English language labels Feb 8, 2019
@netlify
Copy link

netlify bot commented Feb 8, 2019

Deploy preview for kubernetes-io-master-staging ready!

Built with commit cb6a091

https://deploy-preview-12557--kubernetes-io-master-staging.netlify.com

@Rajakavitha1
Copy link
Contributor

Rajakavitha1 commented Feb 12, 2019

/sig apps

@k8s-ci-robot k8s-ci-robot added the sig/apps Categorizes an issue or PR as relevant to SIG Apps. label Feb 12, 2019
@Rajakavitha1
Copy link
Contributor

/assign @MistyHacks

@zparnold
Copy link
Member

Yep, this is the correct syntax :shipit: thanks so much for the contribution!
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 13, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zparnold

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 13, 2019
@k8s-ci-robot k8s-ci-robot merged commit 3eb1148 into kubernetes:master Feb 13, 2019
@oke-py oke-py deleted the update-fluentd branch February 13, 2019 12:22
kwiesmueller pushed a commit to kwiesmueller/website that referenced this pull request Feb 28, 2019
* Update fluentd 0.12 to 1.0 in the example

* .editorconfig removed trailing spaces
krmayankk pushed a commit to krmayankk/kubernetes.github.io that referenced this pull request Mar 11, 2019
* Update fluentd 0.12 to 1.0 in the example

* .editorconfig removed trailing spaces
yagonobre pushed a commit to yagonobre/website that referenced this pull request Mar 14, 2019
* Update fluentd 0.12 to 1.0 in the example

* .editorconfig removed trailing spaces
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/apps Categorizes an issue or PR as relevant to SIG Apps. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants