Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add oidc-required-claim #12536

Merged

Conversation

jmthvt
Copy link
Contributor

@jmthvt jmthvt commented Feb 7, 2019

This PR adds an oidc flag that has been released in Kubernetes 1.11 https://github.com/kubernetes/kubernetes/blob/master/CHANGELOG-1.11.md#sig-auth-1

@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 7, 2019
@netlify
Copy link

netlify bot commented Feb 7, 2019

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 84d6901

https://deploy-preview-12536--kubernetes-io-master-staging.netlify.com

@jmthvt jmthvt force-pushed the feature/add-oidc-required-claim branch from 43e7ec1 to 84d6901 Compare February 7, 2019 11:55
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 7, 2019
@Rajakavitha1
Copy link
Contributor

I checked : https://github.com/kubernetes/kubernetes/blob/master/CHANGELOG-1.11.md#sig-auth-1 and read about:
kube-apiserver: OIDC authentication now supports requiring specific claims with --oidc-required-claim== Previously, there was no mechanism for a user to specify claims in the OIDC authentication process that were requid to be present in the ID Token with an expected value. This version now makes it possible to require claims support for the OIDC authentication. It allows users to pass in a --oidc-required-claims flag, and key=value pairs in the API config, which will ensure that the specified required claims are checked against the ID Token claims. (#62136, @rithujohn191)

/assign @tfogo

@zparnold
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 13, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zparnold

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 13, 2019
@k8s-ci-robot k8s-ci-robot merged commit f75b961 into kubernetes:master Feb 13, 2019
kwiesmueller pushed a commit to kwiesmueller/website that referenced this pull request Feb 28, 2019
krmayankk pushed a commit to krmayankk/kubernetes.github.io that referenced this pull request Mar 11, 2019
yagonobre pushed a commit to yagonobre/website that referenced this pull request Mar 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants