Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #9805 - Correct tags to avoid HTML encoding issue #12523

Merged
merged 1 commit into from
Feb 13, 2019
Merged

Fix #9805 - Correct tags to avoid HTML encoding issue #12523

merged 1 commit into from
Feb 13, 2019

Conversation

daminisatya
Copy link
Contributor

@daminisatya daminisatya commented Feb 6, 2019 •
edited
Loading

There are a couple of encoding issues which are not yet fixed in this issue #9805

The change is made in the following three pages. Attaching before and after changes to view.

  1. https://kubernetes.io/docs/concepts/overview/object-management-kubectl/imperative-command/#how-to-update-objects

screen shot 1940-11-17 at 5 27 29 pm

screen shot 1940-11-17 at 5 28 07 pm

  1. https://kubernetes.io/docs/concepts/workloads/pods/init-containers/#examples

screen shot 1940-11-17 at 5 23 32 pm

screen shot 1940-11-17 at 5 16 03 pm

  1. https://kubernetes.io/docs/tasks/administer-cluster/dns-horizontal-autoscaling/#determining-your-scale-target

screen shot 1940-11-17 at 5 21 37 pm

screen shot 1940-11-17 at 5 22 56 pm

As mentioned in the original Issue, I verified the other links provided and rest all look good/ are fixed.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 6, 2019
@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Feb 6, 2019
@daminisatya
Copy link
Contributor Author

daminisatya commented Feb 6, 2019 •
edited
Loading

/assign @zparnold

@netlify
Copy link

netlify bot commented Feb 6, 2019 •
edited
Loading

Deploy preview for kubernetes-io-master-staging ready!

Built with commit b32dd2e

https://deploy-preview-12523--kubernetes-io-master-staging.netlify.com

@Rajakavitha1
Copy link
Contributor

@daminisatya Thanks for the fix!!!
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 6, 2019
@daminisatya daminisatya mentioned this pull request Feb 6, 2019
Closed
6 tasks
Rajakavitha1
Rajakavitha1 suggested changes Feb 7, 2019
View reviewed changes
Copy link
Contributor

@Rajakavitha1 Rajakavitha1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @daminisatya Thanks for the fix: Could you please change where <dns-deployment-name> is the name of your DNS Deployment. For example, if
your DNS Deployment name is coredns, your scale target is Deployment/coredns. to:
where <your-deployment-name> is the name of your DNS Deployment. For example, if
your DNS Deployment name is coredns, your scale target is Deployment/coredns. to keep it consistent with the command "Deployment/"

@Rajakavitha1
Copy link
Contributor

Rajakavitha1 commented Feb 7, 2019 •
edited
Loading

The updates in the following look good to me:

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 9, 2019
@Rajakavitha1
Copy link
Contributor

/lgtm

@zparnold and @tengqm Please take a look and state your approval.

Rajie

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 9, 2019
@erictune
Copy link
Member

/unassign

@Rajakavitha1
Copy link
Contributor

@tengqm Please take a look and state your approval.

@zparnold
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zparnold

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 13, 2019
@k8s-ci-robot k8s-ci-robot merged commit 63e57d1 into kubernetes:master Feb 13, 2019
kwiesmueller pushed a commit to kwiesmueller/website that referenced this pull request Feb 28, 2019
@daminisatya
Fix kubernetes#9805 - Correct tags to avoid HTML encoding issue (kube…
055a194 
…rnetes#12523)
krmayankk pushed a commit to krmayankk/kubernetes.github.io that referenced this pull request Mar 11, 2019
@daminisatya
Fix kubernetes#9805 - Correct tags to avoid HTML encoding issue (kube…
3a9e9a1 
…rnetes#12523)
yagonobre pushed a commit to yagonobre/website that referenced this pull request Mar 14, 2019
@daminisatya @yagonobre
Fix kubernetes#9805 - Correct tags to avoid HTML encoding issue (kube…
199fd16 
…rnetes#12523)
@daminisatya daminisatya deleted the Fix_Bug_9805 branch March 20, 2019 04:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rajakavitha1 Rajakavitha1 Rajakavitha1 requested changes

@erictune erictune Awaiting requested review from erictune

@xiangpengzhao xiangpengzhao Awaiting requested review from xiangpengzhao

Assignees

@tengqm tengqm

@zparnold zparnold

@Rajakavitha1 Rajakavitha1

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@daminisatya @Rajakavitha1 @erictune @zparnold @k8s-ci-robot @tengqm